linux-kernel - Re: [PATCH v1 3/5] dt-bindings: misc: Move amd,sbrmi.yaml from hwmon to misc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4ccb447f-4995-44b1-822d-1e04e2516416@kernel.org>
Date: Mon, 11 Aug 2025 13:56:18 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Gupta, Akshay" <Akshay.Gupta@....com>, linux-kernel@...r.kernel.org,
 linux-hwmon@...r.kernel.org
Cc: gregkh@...uxfoundation.org, arnd@...db.de, linux@...ck-us.net,
 Anand.Umarji@....com,
 Naveen Krishna Chatradhi <naveenkrishna.chatradhi@....com>
Subject: Re: [PATCH v1 3/5] dt-bindings: misc: Move amd,sbrmi.yaml from hwmon
 to misc

On 11/08/2025 13:54, Gupta, Akshay wrote:
> 
> On 7/29/2025 11:59 AM, Krzysztof Kozlowski wrote:
>> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>>
>>
>> On 28/07/2025 08:10, Akshay Gupta wrote:
>>> - AMD SB-RMI patches are moved from drivers/hwmon to
>>>    drivers/misc to support additional functionality.
>>>    Move the related bindings documentation files to misc.
>>>
>>> Reviewed-by: Naveen Krishna Chatradhi <naveenkrishna.chatradhi@....com>
>> Really? What was reviewed here exactly? Poor style of commit msg or that
>> rename actually does rename?
>>
>>> Signed-off-by: Akshay Gupta <akshay.gupta@....com>
>>> ---
>>>   Documentation/devicetree/bindings/{hwmon => misc}/amd,sbrmi.yaml | 0
>> We don't put bindings into MISC.
> 
> We moved the SB-RMI driver from hwmon to misc, and hence moved the 
> binding documentation.
> 
> Referred the newly added yaml file, ti,fpc202.yaml through commit in the 
> misc bindings.
> 
> If Documentation/devicetree/bindings/misc is not right path, can you 
> please suggest the correct path for bindings for drivers in misc?

I don't know what this hardware is, but "misc" does not sound like class
of hardware devices... Don't just dump stuff there.

Best regards,
Krzysztof