linux-kernel - Re: [PATCH v2] include/linux/rv.h: remove redundant include file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9e3d1c141c1e6609252aa38348986fe1436052b7.camel@redhat.com>
Date: Mon, 11 Aug 2025 14:40:13 +0200
From: Gabriele Monaco <gmonaco@...hat.com>
To: Akhilesh Patil <akhilesh@...iitb.ac.in>, rostedt@...dmis.org, 
	mhiramat@...nel.org, mathieu.desnoyers@...icios.com
Cc: linux-trace-kernel@...r.kernel.org, linux-kernel@...r.kernel.org, 
	akhileshpatilvnit@...il.com, skhan@...uxfoundation.org
Subject: Re: [PATCH v2] include/linux/rv.h: remove redundant include file

On Mon, 2025-08-11 at 17:42 +0530, Akhilesh Patil wrote:
> Remove redundant include <linux/types.h> to clean up the code.
> Move all unique include files inside CONFIG_RV as they are only
> needed when CONFIG_RV is enabled.


> Arrange include files alphabetically.

That is usually not necessary. Also, it shouldn't happen, but sometimes
the order of inclusion matters. Anyway this isn't the case here (builds
fine locally) and when it is, the test robot should notice.


Looks good to me overall, thanks!
Reviewed-by: Gabriele Monaco <gmonaco@...hat.com>

> 
> Fixes: 24cbfe18d55a ("rv: Merge struct rv_monitor_def into struct
> rv_monitor") [1]
> Reported-by: kernel test robot <lkp@...el.com>
> Closes:
> https://lore.kernel.org/r/202507312017.oyD08TL5-lkp@intel.com/
> Signed-off-by: Akhilesh Patil <akhilesh@...iitb.ac.in>
> ---
>  include/linux/rv.h | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/include/linux/rv.h b/include/linux/rv.h
> index 14410a42faef..9520aab34bcb 100644
> --- a/include/linux/rv.h
> +++ b/include/linux/rv.h
> @@ -7,16 +7,14 @@
>  #ifndef _LINUX_RV_H
>  #define _LINUX_RV_H
>  
> -#include <linux/types.h>
> -#include <linux/list.h>
> -
>  #define MAX_DA_NAME_LEN			32
>  #define MAX_DA_RETRY_RACING_EVENTS	3
>  
>  #ifdef CONFIG_RV
> +#include <linux/array_size.h>
>  #include <linux/bitops.h>
> +#include <linux/list.h>
>  #include <linux/types.h>
> -#include <linux/array_size.h>
>  
>  /*
>   * Deterministic automaton per-object variables.