linux-kernel - Re: [PATCH] platform/x86: barco-p50-gpio: use software nodes for gpio-leds/keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aJnlnx2qF6P61jJN@smile.fi.intel.com>
Date: Mon, 11 Aug 2025 15:44:15 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: Santosh Kumar Yadav <santoshkumar.yadav@...co.com>,
	Hans de Goede <hansg@...nel.org>,
	Peter Korsgaard <peter.korsgaard@...co.com>,
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	Arnd Bergmann <arnd@...db.de>, platform-driver-x86@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: barco-p50-gpio: use software nodes for
 gpio-leds/keys

On Sun, Aug 10, 2025 at 09:31:37PM -0700, Dmitry Torokhov wrote:
> In preparation of dropping support for legacy GPIO API from gpio-keys
> switch the driver to use software nodes/properties to describe
> GPIO-connected LED and button.

...

>  #include <linux/delay.h>
> +#include <linux/dev_printk.h>
>  #include <linux/dmi.h>
>  #include <linux/err.h>
>  #include <linux/io.h>

>  #include <linux/leds.h>
>  #include <linux/module.h>
>  #include <linux/platform_device.h>
> -#include <linux/gpio_keys.h>
>  #include <linux/gpio/driver.h>
>  #include <linux/gpio/machine.h>
> -#include <linux/input.h>

> +#include <linux/gpio/property.h>
> +#include <linux/input-event-codes.h>
> +#include <linux/property.h>

The idea of sorting here is to have more generic first and then more specific
(per subsystem in use) groups of headers. So with your change it should look
like

#include <linux/delay.h>
#include <linux/dev_printk.h>
#include <linux/dmi.h>
#include <linux/err.h>
#include <linux/io.h>
...
#include <linux/leds.h>
#include <linux/module.h>
#include <linux/platform_device.h>
#include <linux/property.h>

#include <linux/gpio/driver.h>
#include <linux/gpio/machine.h>
#include <linux/gpio/property.h>

#include <linux/input-event-codes.h>

(I also added blank lines to make it more explicit)

...

Otherwise LGTM as here it looks like we establish platform device ourselves and
hence no need some additional magic Hans mentioned in the other series.

-- 
With Best Regards,
Andy Shevchenko