linux-kernel - Re: [PATCH 21/21] gpiolib: turn off legacy interface by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aJnm2dpNWJDXbTb5@smile.fi.intel.com>
Date: Mon, 11 Aug 2025 15:49:29 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Arnd Bergmann <arnd@...db.de>
Cc: Arnd Bergmann <arnd@...nel.org>, Bartosz Golaszewski <brgl@...ev.pl>,
	Linus Walleij <linus.walleij@...aro.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
	Peng Fan <peng.fan@....com>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Koichiro Den <koichiro.den@...onical.com>,
	André Draszik <andre.draszik@...aro.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 21/21] gpiolib: turn off legacy interface by default

On Sat, Aug 09, 2025 at 09:47:31PM +0200, Arnd Bergmann wrote:
> On Sat, Aug 9, 2025, at 12:18, Andy Shevchenko wrote:
> > On Fri, Aug 08, 2025 at 05:18:06PM +0200, Arnd Bergmann wrote:
> >
> >> All users of the legacy interface now select CONFIG_GPIOLIB_LEGACY,
> >> so it can be turned off by default.
> >> 
> >> Allow turning it on manually for compile testing, in order to keep
> >> the build coverage of the legacy drivers.
> >
> >>  config GPIOLIB_LEGACY
> >> -	def_bool y
> >> +	bool "Legacy GPIO interfaces" if COMPILE_TEST
> >
> > Maybe I'm missing something, but how does it supposed to be compiled for old
> > platforms? (No, COMPILE_TEST is not a correct option for that)
> > Perhaps you meant EXPERT ?
> 
> The COMPILE_TEST is really just meant for enabling some drivers
> that would otherwise be skipped in allmodconfig builds.
> 
> All the old platforms that use one of the GPIOLIB_LEGACY drivers
> select that symbol once the first six patches are merged.

Ah, that makes sense. Perhaps a word to be added into commit message?

-- 
With Best Regards,
Andy Shevchenko