linux-kernel - Re: [PATCH v8 3/6] rust: irq: add support for non-threaded IRQs and handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <77FB27DB-ACE0-4AC4-A3D9-CCF1EB4A34D2@collabora.com>
Date: Mon, 11 Aug 2025 09:55:29 -0300
From: Daniel Almeida <daniel.almeida@...labora.com>
To: Alice Ryhl <aliceryhl@...gle.com>
Cc: Miguel Ojeda <ojeda@...nel.org>,
 Alex Gaynor <alex.gaynor@...il.com>,
 Boqun Feng <boqun.feng@...il.com>,
 Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Andreas Hindborg <a.hindborg@...nel.org>,
 Trevor Gross <tmgross@...ch.edu>,
 Danilo Krummrich <dakr@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 "Rafael J. Wysocki" <rafael@...nel.org>,
 Thomas Gleixner <tglx@...utronix.de>,
 Bjorn Helgaas <bhelgaas@...gle.com>,
 Krzysztof Wilczyński <kwilczynski@...nel.org>,
 Benno Lossin <lossin@...nel.org>,
 linux-kernel@...r.kernel.org,
 rust-for-linux@...r.kernel.org,
 linux-pci@...r.kernel.org,
 Joel Fernandes <joelagnelf@...dia.com>,
 Dirk Behme <dirk.behme@...bosch.com>
Subject: Re: [PATCH v8 3/6] rust: irq: add support for non-threaded IRQs and
 handlers

> On 11 Aug 2025, at 09:43, Alice Ryhl <aliceryhl@...gle.com> wrote:
> 
> On Mon, Aug 11, 2025 at 2:38 PM Daniel Almeida
> <daniel.almeida@...labora.com> wrote:
>> 
>> 
>>>> Also, I was getting tons of “unreachable_pub” warnings
>>>> otherwise, FYI.
>>> 
>>> If you got unreachable_pub warnings, then you are missing re-exports.
>>> 
>>> Alice
>> 
>> The re-exports are as-is in the current patch, did I miss anything? Because I
>> don’t think so.
>> 
>> In particular, should the irq module itself be private?
> 
> No, the end-user should be able to write
> 
>    use kernel::irq::Flags;
> 
> so the irq module needs to be public.
> 
> Alice

Ah, maybe this is the issue then, i.e [0]:

```
(This requires a re-export in the irq module if you don't have one
already. Also, I would make the irq module private so that end-users
import everything via the irq:: path without a sub-module.)
```

Fine, let me try this again.

— Daniel

[0]: https://lore.kernel.org/all/aH5TMzJGqzg3wNjK@google.com/