linux-kernel - Re: [PATCH v2] platform/x86: dell-smbios-wmi: Stop touching WMI device ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <175500171231.2252.13719056870824439306.b4-ty@linux.intel.com>
Date: Tue, 12 Aug 2025 15:28:32 +0300
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: hansg@...nel.org, Armin Wolf <W_Armin@....de>
Cc: Dell.Client.Kernel@...l.com, platform-driver-x86@...r.kernel.org, 
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] platform/x86: dell-smbios-wmi: Stop touching WMI
 device ID

On Tue, 22 Jul 2025 20:38:41 +0200, Armin Wolf wrote:

> The Dell SMBIOS driver uses the "id" field inside struct device for
> prioritizing the WMI backend over the SMM backend. Because of this
> the WMI backend modifies the "id" field of the underlying WMI device.
> However the WMI core itself uses wdev->dev.id internally to track
> device IDs, so modifying this value will result in a resource leak.
> 
> Fix this by not using the "id" field inside struct device for SMBIOS
> prioritization. Instead extend struct smbios_device with a separate
> "priority" field.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: dell-smbios-wmi: Stop touching WMI device ID
      commit: d26a9f4f0a7745f0d5127344379a62007df68dcd

--
 i.