linux-kernel - Re: [PATCH v2 5/7] media: rkvdec: Disable QoS for HEVC and VP9 on RK3328

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dc95a2e6283badfd03bc9b0cb1b1f4ff2a0558dc.camel@collabora.com>
Date: Tue, 12 Aug 2025 08:47:07 -0400
From: Nicolas Dufresne <nicolas.dufresne@...labora.com>
To: Jonas Karlman <jonas@...boo.se>
Cc: Ezequiel Garcia <ezequiel@...guardiasur.com.ar>, Detlev Casanova	
 <detlev.casanova@...labora.com>, Mauro Carvalho Chehab
 <mchehab@...nel.org>,  Heiko Stuebner	 <heiko@...ech.de>, Alex Bee
 <knaerzche@...il.com>, Sebastian Fricke	 <sebastian.fricke@...labora.com>,
 linux-media@...r.kernel.org, 	linux-rockchip@...ts.infradead.org,
 devicetree@...r.kernel.org, 	linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 5/7] media: rkvdec: Disable QoS for HEVC and VP9 on
 RK3328

Le mardi 12 août 2025 à 00:22 +0200, Jonas Karlman a écrit :
> > >  #define RKVDEC_CAPABILITY_H264		BIT(1)
> > >  #define RKVDEC_CAPABILITY_VP9		BIT(2)
> > >  
> > > +#define RKVDEC_QUIRK_DISABLE_QOS	BIT(0)
> > 
> > Can you go back in the series, get H264 into bit 0, VP9 into bit 1, and set
> > quirks from bit 16 ? Just worried the whole finding can becomes a mess in
> > many
> > years from now.
> 
> The reason for HEVC in bit 0 is mainly because the first generation was
> HEVC only, this also matches the mode reg values (0=hevc, 1=h264, 2=vp9).
> 
> I can start quirk at bit 16 if you like, not really sure I understand
> why? Do you want to combine capabilities and quirks into one?

My bad, I miss-understood the code. The Quirk bits are seperate, not filling a
gap.

cheers,
Nicolas

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)