linux-kernel - Re: [PATCH] selftests/damon: fix damon selftests by installing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABFDxMEQYx7fdx4T7meUb01FoqJaHcW_2RoYnBwJ8GzmJTexzQ@mail.gmail.com>
Date: Tue, 12 Aug 2025 22:27:00 +0900
From: Sang-Heon Jeon <ekffu200098@...il.com>
To: Alexandre Ghiti <alexghiti@...osinc.com>
Cc: SeongJae Park <sj@...nel.org>, Shuah Khan <shuah@...nel.org>, 
	Andrew Morton <akpm@...ux-foundation.org>, Enze Li <lienze@...inos.cn>, damon@...ts.linux.dev, 
	linux-mm@...ck.org, linux-kselftest@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests/damon: fix damon selftests by installing _common.sh

Hello, Alexandre

On Tue, Aug 12, 2025 at 9:32 PM Sang-Heon Jeon <ekffu200098@...il.com> wrote:
>
> Hello, Alexandre
>
> On Tue, Aug 12, 2025 at 5:13 PM Alexandre Ghiti <alexghiti@...osinc.com> wrote:
> >
> > _common.sh was recently introduced but is not installed and then
> > triggers an error when trying to run the damon selftests:
> >
> > selftests: damon: sysfs.sh
> > ./sysfs.sh: line 4: _common.sh: No such file or directory
> >
> > Install this file to avoid this error.
>
> I tried to reproduce those error with my vm environment but I failed;
> with my workaround test method, it doesn't exist.
> If you're okay, could you please tell me line by line how you execute
> tests in what environment?
> I'm also struggling with the test environment, as well.

I succeeded to reproduce and also check that this patch removes those errors.

> > Fixes: 511914506d19 ("selftests/damon: introduce _common.sh to host shared function")
> > Signed-off-by: Alexandre Ghiti <alexghiti@...osinc.com>
> > ---

Tested-by: Sang-Heon Jeon <ekffu200098@...il.com>

> >  tools/testing/selftests/damon/Makefile | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/testing/selftests/damon/Makefile b/tools/testing/selftests/damon/Makefile
> > index 5b230deb19e8ee6cee56eb8f18c35e12f331e8b7..ddc69e8bde2905ff1c461a08f2ad008e6b28ac87 100644
> > --- a/tools/testing/selftests/damon/Makefile
> > +++ b/tools/testing/selftests/damon/Makefile
> > @@ -4,6 +4,7 @@
> >  TEST_GEN_FILES += access_memory access_memory_even
> >
> >  TEST_FILES = _damon_sysfs.py
> > +TEST_FILES += _common.sh
> >
> >  # functionality tests
> >  TEST_PROGS += sysfs.sh
> >
> > ---
> > base-commit: 2754d549af31f8f029f02d02cd8e574676229b3d
>
> Does this commit exist in `mm-new` or `damon-next`?  I failed to setup
> the same base-commit environment.

However, I'm still not sure that this patch is in the correct
baseline. maybe it will not cause any problems with the merge
though... but I'm not sure. So I didn't add a reviewed-by tag.

> > change-id: 20250812-alex-fixes_manual-aed3ef75dd83
> >
> > Best regards,
> > --
> > Alexandre Ghiti <alexghiti@...osinc.com>
> >
> >
>
> Thank you for great work!
>
> Best Regards.
> Sang-Heon Jeon

Best Regards.
Sang-Heon Jeon