linux-kernel - Re: [PATCH] iio: iio_format_list() should set stride=1 for IIO_VAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36e135d2-0952-484f-ac6b-b753dbc1b4db@baylibre.com>
Date: Tue, 12 Aug 2025 09:14:21 -0500
From: David Lechner <dlechner@...libre.com>
To: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
 Jonathan Cameron <jic23@...nel.org>, Nuno Sá
 <nuno.sa@...og.com>, Andy Shevchenko <andy@...nel.org>
Subject: Re: [PATCH] iio: iio_format_list() should set stride=1 for
 IIO_VAL_CHAR

On 8/12/25 6:12 AM, Ben Collins wrote:
> iio_format_list() sets a stride across the val array of 1 for INT
> type, and 2 for all others. Add IIO_VAL_CHAR so it also gets a
> stride of 1 assuming val is an array of integers with char type
> values.
> 
> No drivers currently use this, but I found this issue adding an
> avail callback for IIO_INFO_THERMOCOUPLE_TYPE for a driver I'm
> working on.
> 
> Signed-off-by: Ben Collins <bcollins@...nel.org>
> Cc: Jonathan Cameron <jic23@...nel.org>
> Cc: David Lechner <dlechner@...libre.com>
> Cc: Nuno Sá <nuno.sa@...log.com>
> Cc: Andy Shevchenko <andy@...nel.org>
> 
> ---
>  drivers/iio/industrialio-core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> index 159d6c5ca3cec..eb6a54f8115de 100644
> --- a/drivers/iio/industrialio-core.c
> +++ b/drivers/iio/industrialio-core.c
> @@ -790,6 +790,7 @@ static ssize_t iio_format_list(char *buf, const int *vals, int type, int length,
>  
>  	switch (type) {
>  	case IIO_VAL_INT:
> +	case IIO_VAL_CHAR:
>  		stride = 1;
>  		break;
>  	default:

Reviewed-by: David Lechner <dlechner@...libre.com>