linux-kernel - Re: [PATCH] vfs: show filesystem name at dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <370cbc89-721c-46aa-9f6e-1681f5d04e99@I-love.SAKURA.ne.jp>
Date: Wed, 13 Aug 2025 00:22:55 +0900
From: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
To: Christian Brauner <brauner@...nel.org>
Cc: linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Alexander Viro
 <viro@...iv.linux.org.uk>, Jan Kara <jack@...e.cz>,
        Mateusz Guzik <mjguzik@...il.com>
Subject: Re: [PATCH] vfs: show filesystem name at dump_inode()

On 2025/08/11 22:51, Christian Brauner wrote:
> On Mon, 11 Aug 2025 15:50:28 +0900, Tetsuo Handa wrote:
>> Commit 8b17e540969a ("vfs: add initial support for CONFIG_DEBUG_VFS") added
>> dump_inode(), but dump_inode() currently reports only raw pointer address.
>> Comment says that adding a proper inode dumping routine is a TODO.
>>
>> However, syzkaller concurrently tests multiple filesystems, and several
>> filesystems started calling dump_inode() due to hitting VFS_BUG_ON_INODE()
>> added by commit af153bb63a33 ("vfs: catch invalid modes in may_open()")
>> before a proper inode dumping routine is implemented.
>>
>> [...]
> 
> Applied to the vfs-6.18.misc branch of the vfs/vfs.git tree.
> Patches in the vfs-6.18.misc branch should appear in linux-next soon.

It would be nice if we can get this patch merged into linux.git in 2 weeks, for
https://syzkaller.appspot.com/bug?extid=895c23f6917da440ed0d is hitting on more
filesystems where a reproducer is not yet available.

> 
> Please report any outstanding bugs that were missed during review in a
> new review to the original patch series allowing us to drop it.
> 
> It's encouraged to provide Acked-bys and Reviewed-bys even though the
> patch has now been applied. If possible patch trailers will be updated.
> 
> Note that commit hashes shown below are subject to change due to rebase,
> trailer updates or similar. If in doubt, please check the listed branch.
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
> branch: vfs-6.18.misc
> 
> [1/1] vfs: show filesystem name at dump_inode()
>       https://git.kernel.org/vfs/vfs/c/ecb060536446