linux-kernel - Re: [PATCH v3] drm/mediatek: dp: Fix suspend/resume training failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c5abc7ac387a2bd51d000ca95bb90f37b097d0d0.camel@mediatek.com>
Date: Tue, 12 Aug 2025 00:46:26 +0000
From: CK Hu (胡俊光) <ck.hu@...iatek.com>
To: "towwy321@...il.com" <towwy321@...il.com>, "chunkuang.hu@...nel.org"
	<chunkuang.hu@...nel.org>, "simona@...ll.ch" <simona@...ll.ch>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	"airlied@...il.com" <airlied@...il.com>, "msp@...libre.com"
	<msp@...libre.com>, "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
	"matthias.bgg@...il.com" <matthias.bgg@...il.com>, "granquet@...libre.com"
	<granquet@...libre.com>
CC: Rex-BC Chen (陳柏辰) <Rex-BC.Chen@...iatek.com>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] drm/mediatek: dp: Fix suspend/resume training failure

On Mon, 2025-08-11 at 17:28 +0800, CK Hu wrote:
> On Sun, 2025-08-10 at 14:17 +0800, Haru Zheng wrote:
> > External email : Please do not click links or open attachments until you have verified the sender or the content.
> > 
> > 
> > When suspending and resuming DisplayPort via Type-C,
> > link training will be fail.
> > 
> > This patch backports the software IRQ handling for DP,
> > as eDP uses hardware IRQ while DP uses software IRQ.
> 
> This patch just modify the flow of DP, not eDP, so do not mention eDP here.
> For DP, I don't know why hardware IRQ would fail.
> HDMI support suspend and resume and it does not software IRQ.
> Please describe the hardware behavior when resume and point out why hardware would not trigger hardware hot plug interrupt.

In addition, resume flow is similar to boot up flow.

In boot up flow, the step is:
1. Plug in cable
2. Power on DP hardware.
3. DP HDP hardware interrupt happen.

So, in resume flow:
1. Plug in cable
2. Power on DP hardware
3. DP HDP hardware interrupt happen. (disappear?)

The flow is the same, why resume has no hardware interrupt?

Regards,
CK

> 
> > Additionally, cable_plugged_in is flipped in
> > mtk_dp_hpd_event to ensure correct hotplug detection
> > during resume.
> > 
> > These changes fix the DP training failure after suspend/resume.
> > 
> > Fixes: f70ac097a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort driver")
> > Signed-off-by: Haru Zheng <towwy321@...il.com>
> > 
> > ---