linux-kernel - [PATCH] ext4: remove branch to identical code ext4_init_new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250812165331.8449-1-sperezglz@gmail.com>
Date: Tue, 12 Aug 2025 10:53:28 -0600
From: Sergio Perez Gonzalez <sperezglz@...il.com>
To: tytso@....edu,
	adilger.kernel@...ger.ca
Cc: Sergio Perez Gonzalez <sperezglz@...il.com>,
	linux-ext4@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH] ext4: remove branch to identical code ext4_init_new_dir()

It seems unnecessary to use a branch, in the event of
error, to the same target label that would execute on
success.

Signed-off-by: Sergio Perez Gonzalez <sperezglz@...il.com>
---
 fs/ext4/namei.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index d83f91b62317..01f379f5fd04 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -2984,8 +2984,6 @@ int ext4_init_new_dir(handle_t *handle, struct inode *dir,
 		return PTR_ERR(dir_block);
 	de = (struct ext4_dir_entry_2 *)dir_block->b_data;
 	err = ext4_init_dirblock(handle, inode, dir_block, dir->i_ino, NULL, 0);
-	if (err)
-		goto out;
 out:
 	brelse(dir_block);
 	return err;
-- 
2.43.0