linux-kernel - Re: [PATCH 0/3] rtla: fix cgroup and trace options parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cxc4vnifqfnizy6xx3m7rwyz442fur7stbfqas3qxat2opq5sv@zt2eerzhnwr4>
Date: Tue, 12 Aug 2025 13:23:24 -0400
From: Ivan Pravdin <ipravdin.official@...il.com>
To: rostedt@...dmis.org, corbet@....net, tglozar@...hat.com, 
	linux-trace-kernel@...r.kernel.org, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] rtla: fix cgroup and trace options parsing

On Tue, Aug 12, 2025 at 12:27:29PM -0400, Ivan Pravdin wrote:
> This series fixes 3 issue in rtla timerlat and osnoise parsing.
> 
> 1. Fix buffer overflow when using --on-threshold option. Currently
>    passing `--on-threshold trace` causes rtla timerlat to segfault.
>    First patch addresses this issue.
> 
> 2. Make -C/--cgroup option more user-friendly. Currently rtla timerlat
>    and osnoise parses does not allow to specify tracer's threads cgroup
>    name as `-C [cgroup]` or `--cgroup [cgroup]`. Second patch fixes this by
>    allowing users to specify cgroup in the aforementioned manner.
> 
> 3. When specifying `-t/--trace` before `-a/--auto`, trace filename is
>    override to default <osnoise|timerlat>_trace.txt. For example, when
>    running rtla as 
>     
>        `rtla timerlat top -t custom_file.txt -a 100`
> 
>    when the threshold is reached, timerlat_trace.txt file is created
>    instead of specified custom_file.txt. Third patch addresses this issue.
> 
> Ivan Pravdin (3):
>   rtla: fix buffer overflow in actions_parse
>   rtla: fix -C/--cgroup interface
>   rtla: fix -a overriding -t argument
> 
>  Documentation/tools/rtla/common_options.rst |  2 +-
>  tools/tracing/rtla/src/actions.c            |  2 +-
>  tools/tracing/rtla/src/osnoise_hist.c       | 24 ++++++++------
>  tools/tracing/rtla/src/osnoise_top.c        | 24 ++++++++------
>  tools/tracing/rtla/src/timerlat_hist.c      | 24 ++++++++------
>  tools/tracing/rtla/src/timerlat_top.c       | 36 +++++++++------------
>  6 files changed, 62 insertions(+), 50 deletions(-)
> 
> -- 
> 2.48.1
>

Please disregard this and see v2 [1]

[1] https://lore.kernel.org/all/cover.1755018581.git.ipravdin.official@gmail.com/T/#t

	Ivan Pravdin