linux-kernel - Re: [PATCH v2 1/2] ubifs: Remove unnecessary parameters '*c'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <be8c49cd-82e9-10ff-30d6-f5dfd461d731@huawei.com>
Date: Tue, 12 Aug 2025 11:06:20 +0800
From: Zhihao Cheng <chengzhihao1@...wei.com>
To: Xichao Zhao <zhao.xichao@...o.com>, Richard Weinberger <richard@....at>,
	"open list:UBI FILE SYSTEM (UBIFS)" <linux-mtd@...ts.infradead.org>, open
 list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] ubifs: Remove unnecessary parameters '*c'

在 2025/8/12 10:10, Xichao Zhao 写道:
> Because the variable *c is not used within the function,
> remove it from the ubifs_crc_node function.
> 
> Signed-off-by: Xichao Zhao <zhao.xichao@...o.com>
> ---
>   fs/ubifs/io.c    | 4 ++--
>   fs/ubifs/ubifs.h | 2 +-
>   2 files changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Zhihao Cheng <chengzhihao1@...wei.com>
> 
> diff --git a/fs/ubifs/io.c b/fs/ubifs/io.c
> index a79f229df475..e0dfe6827d65 100644
> --- a/fs/ubifs/io.c
> +++ b/fs/ubifs/io.c
> @@ -395,7 +395,7 @@ void ubifs_init_node(struct ubifs_info *c, void *node, int len, int pad)
>   	}
>   }
>   
> -void ubifs_crc_node(struct ubifs_info *c, void *node, int len)
> +void ubifs_crc_node(void *node, int len)
>   {
>   	struct ubifs_ch *ch = node;
>   	uint32_t crc;
> @@ -432,7 +432,7 @@ int ubifs_prepare_node_hmac(struct ubifs_info *c, void *node, int len,
>   			return err;
>   	}
>   
> -	ubifs_crc_node(c, node, len);
> +	ubifs_crc_node(node, len);
>   
>   	return 0;
>   }
> diff --git a/fs/ubifs/ubifs.h b/fs/ubifs/ubifs.h
> index 5db45c9e26ee..5d172509091a 100644
> --- a/fs/ubifs/ubifs.h
> +++ b/fs/ubifs/ubifs.h
> @@ -1743,7 +1743,7 @@ int ubifs_write_node_hmac(struct ubifs_info *c, void *buf, int len, int lnum,
>   int ubifs_check_node(const struct ubifs_info *c, const void *buf, int len,
>   		     int lnum, int offs, int quiet, int must_chk_crc);
>   void ubifs_init_node(struct ubifs_info *c, void *buf, int len, int pad);
> -void ubifs_crc_node(struct ubifs_info *c, void *buf, int len);
> +void ubifs_crc_node(void *buf, int len);
>   void ubifs_prepare_node(struct ubifs_info *c, void *buf, int len, int pad);
>   int ubifs_prepare_node_hmac(struct ubifs_info *c, void *node, int len,
>   			    int hmac_offs, int pad);
>