linux-kernel - Re: [PATCH v2] mm/numa_memblks: Use pr_debug instead of printk(KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALzOmR1BoVs4LGaygpE-fiKsRztCh4_tsESyFTT5qiHtup5E7w@mail.gmail.com>
Date: Tue, 12 Aug 2025 08:43:48 +0530
From: Pratyush Brahma <pratyush.brahma@....qualcomm.com>
To: Joshua Hahn <joshua.hahnjy@...il.com>
Cc: Mike Rapoport <rppt@...nel.org>, Andrew Morton <akpm@...ux-foundation.org>,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mm/numa_memblks: Use pr_debug instead of printk(KERN_DEBUG)

On Mon, Aug 11, 2025 at 7:33 PM Joshua Hahn <joshua.hahnjy@...il.com> wrote:
>
> On Mon, 11 Aug 2025 11:01:32 +0300 Mike Rapoport <rppt@...nel.org> wrote:
>
> > On Mon, Aug 11, 2025 at 12:13:54PM +0530, pratyush.brahma@....qualcomm.com wrote:
> > > From: Pratyush Brahma <pratyush.brahma@....qualcomm.com>
> > >
> > > Replace the direct usage of printk(KERN_DEBUG ...) with pr_debug(...) to
> > > align with the consistent `pr_*` API usage within the file.
> > >
> > > Reviewed-by: Joshua Hahn <joshua.hahnjy@...il.com>
> > > Signed-off-by: Pratyush Brahma <pratyush.brahma@....qualcomm.com>
> > > ---
> > > Changes in v2:
> > > - Removed printk header as suggested by Joshua.
> > > - Link to v1: https://lore.kernel.org/r/20250808-numa-dbg-v1-1-2ddd1ec634aa@oss.qualcomm.com
> > > ---
> > >  mm/numa_memblks.c | 3 +--
> > >  1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > > diff --git a/mm/numa_memblks.c b/mm/numa_memblks.c
> > > index 541a99c4071a67e5b0ef66f4136dee268a880003..ed6fcfca057ab4c9a8aa26cd1929551b4ded4a5b 100644
> > > --- a/mm/numa_memblks.c
> > > +++ b/mm/numa_memblks.c
> > > @@ -2,7 +2,6 @@
> > >
> > >  #include <linux/array_size.h>
> > >  #include <linux/sort.h>
> > > -#include <linux/printk.h>
> >
> > Please don't, pr_debug is defined there.
>
> Hello Mike, you're totally right, sorry about the incorrect feedback.
> For some reason I completely missed this dependency when reviewing.
> Joshua

While the current patch compiles fine as some other header includes printk,
I see sense in Mike's suggestion to keep the printk header. I'll
revert to my original patch
in the next iteration. Joshua, would you be okay with me keeping your R-by tag
in the original implementation?
>
> Sent using hkml (https://github.com/sjp38/hackermail)

Thanks and Regards
Pratyush