linux-kernel - Re: [PATCH v9 0/7] rust: add support for request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <6B887813-8FA6-4627-9527-76547508E66A@collabora.com>
Date: Tue, 12 Aug 2025 16:17:25 -0300
From: Daniel Almeida <daniel.almeida@...labora.com>
To: Danilo Krummrich <dakr@...nel.org>
Cc: Miguel Ojeda <ojeda@...nel.org>,
 Alex Gaynor <alex.gaynor@...il.com>,
 Boqun Feng <boqun.feng@...il.com>,
 Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Andreas Hindborg <a.hindborg@...nel.org>,
 Alice Ryhl <aliceryhl@...gle.com>,
 Trevor Gross <tmgross@...ch.edu>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 "Rafael J. Wysocki" <rafael@...nel.org>,
 Thomas Gleixner <tglx@...utronix.de>,
 Bjorn Helgaas <bhelgaas@...gle.com>,
 Krzysztof Wilczyński <kwilczynski@...nel.org>,
 Benno Lossin <lossin@...nel.org>,
 linux-kernel@...r.kernel.org,
 rust-for-linux@...r.kernel.org,
 linux-pci@...r.kernel.org,
 Joel Fernandes <joelagnelf@...dia.com>,
 Dirk Behme <dirk.behme@...bosch.com>
Subject: Re: [PATCH v9 0/7] rust: add support for request_irq

Hi Danilo,

> On 12 Aug 2025, at 16:07, Danilo Krummrich <dakr@...nel.org> wrote:
> 
> On Mon Aug 11, 2025 at 6:03 PM CEST, Daniel Almeida wrote:
> 
> Applied to driver-core-testing, thanks!

Awesome, thanks everyone involved here :)

> 
>> Alice Ryhl (1):
>>      rust: irq: add &Device<Bound> argument to irq callbacks
>> 
>> Daniel Almeida (6):
>>      rust: irq: add irq module
>>      rust: irq: add flags module
> 
>    [ Use expect(dead_code) for into_inner(), fix broken intra-doc link and
>      typo. - Danilo ]

Right, I’ll consider inter-patch issues like this in the future, sorry.

[…]

> 
>    [ Remove expect(dead_code) from IrqRequest::new(), re-format macros and
>      macro invocations to not exceed 100 characters line length. - Danilo ]
> 
>>      rust: pci: add irq accessors
> 

How? rustfmt doesn’t format this, so I assume that you just manually
wrapped the lines in a suitable way?

— Daniel