linux-kernel - Re: [PATCH] PCI: vmd: Remove MSI-X check on child devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aJuY1o4JAftObQhv@kbusch-mbp>
Date: Tue, 12 Aug 2025 13:41:10 -0600
From: Keith Busch <kbusch@...nel.org>
To: Nam Cao <namcao@...utronix.de>
Cc: Bjorn Helgaas <helgaas@...nel.org>,
	Nirmal Patel <nirmal.patel@...ux.intel.com>,
	Jonathan Derrick <jonathan.derrick@...ux.dev>,
	Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Krzysztof Wilczy´nski <kwilczynski@...nel.org>,
	Manivannan Sadhasivam <mani@...nel.org>,
	Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
	Thomas Gleixner <tglx@...utronix.de>, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org, Ammar Faizi <ammarfaizi2@...weeb.org>
Subject: Re: [PATCH] PCI: vmd: Remove MSI-X check on child devices

On Tue, Aug 12, 2025 at 09:32:19PM +0200, Nam Cao wrote:
> On Tue, Aug 12, 2025 at 02:00:36PM -0500, Bjorn Helgaas wrote:
> > On Tue, Aug 12, 2025 at 08:22:09PM +0200, Nam Cao wrote:
> > > Minor correction, it is not just an unnecessary WARN_ON, but child devices'
> > > drivers couldn't enable MSI at all.
> > > 
> > > So perhaps something like "Remove the sanity check to allow child devices
> > > which only support MSI".
> > 
> > Thanks, updated.
> 
> Sorry for the extra work I have been putting on you this cycle. I trust you
> understand it is for good reason.
> 
> It is unfortunate that I do not have hardware for most patches I sent. The
> best I could do was staring at the patches until I think "yeah, that
> probably isn't broken". That obviously isn't good enough to remove all
> bugs. I wish that I could do better, but oh well...
> 
> Thanks Ammar as well, for helping me tracking down this bug.
> 
> I hope this one is the last regression report that we will see.

I'm sure intel can get you a proper hardware spec. Referencing marketing
white paper material to guide software changes is not a good idea. :)