linux-kernel - Re: [PATCH RFC 04/29] fsverity: add per-sb workqueue for post read processing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aJubdUBFAFnxe7C_@slm.duckdns.org>
Date: Tue, 12 Aug 2025 09:52:21 -1000
From: Tejun Heo <tj@...nel.org>
To: Christoph Hellwig <hch@....de>
Cc: Andrey Albershteyn <aalbersh@...hat.com>, fsverity@...ts.linux.dev,
	linux-fsdevel@...r.kernel.org, linux-xfs@...r.kernel.org,
	david@...morbit.com, djwong@...nel.org, ebiggers@...nel.org,
	Lai Jiangshan <jiangshanlai@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC 04/29] fsverity: add per-sb workqueue for post read
 processing

Hello,

On Tue, Aug 12, 2025 at 09:43:50AM +0200, Christoph Hellwig wrote:
...
> Andrey (or others involved with previous versions):  is interference
> with the log completion workqueue what you ran into?
> 
> Tejun, are you going to prepare a patch to fix the rescuer priority?

NVM, I was confused. All rescuers, regardless of the associated workqueue,
set their nice level to MIN_NICE. IIRC, the rationale was that by the time
rescuer triggers the queued work items already have experienced noticeable
latencies and that rescuer invocations would be pretty rare. I'd be
surprised if rescuer behavior is showing up as easily observable
interferences in most cases. The system should already be thrashing quite a
bit for rescuers to be active and whatever noise rescuer behavior might
cause should usually be drowned by other things.

Thanks.

-- 
tejun