linux-kernel - Re: [PATCH v2] clocksource: hyper-v: Skip unnecessary checks for the root partition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2c1fcdbb-5b50-4a41-9adf-f3b815624f81@linux.microsoft.com>
Date: Tue, 12 Aug 2025 13:30:03 -0700
From: Nuno Das Neves <nunodasneves@...ux.microsoft.com>
To: Wei Liu <wei.liu@...nel.org>,
 Linux on Hyper-V List <linux-hyperv@...r.kernel.org>
Cc: mhklinux@...look.com, "K. Y. Srinivasan" <kys@...rosoft.com>,
 Haiyang Zhang <haiyangz@...rosoft.com>, Dexuan Cui <decui@...rosoft.com>,
 Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
 Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>,
 "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@...nel.org>,
 "H. Peter Anvin" <hpa@...or.com>, Daniel Lezcano
 <daniel.lezcano@...aro.org>,
 "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] clocksource: hyper-v: Skip unnecessary checks for the
 root partition

On 8/12/2025 2:48 PM, Wei Liu wrote:
> The HV_ACCESS_TSC_INVARIANT bit is always zero when Linux runs as the
> root partition. The root partition will see directly what the hardware
> provides.
> 
> The old logic in ms_hyperv_init_platform caused the native TSC clock
> source to be incorrectly marked as unstable on x86. Fix it.
> 
> Skip the unnecessary checks in code for the root partition. Add one
> extra comment in code to clarify the behavior.
> 
> Signed-off-by: Wei Liu <wei.liu@...nel.org>
> ---
> v2: update the commit message and comments
> ---
>  arch/x86/kernel/cpu/mshyperv.c     | 11 ++++++++++-
>  drivers/clocksource/hyperv_timer.c | 10 +++++++++-
>  2 files changed, 19 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c
> index c78f860419d6..25773af116bc 100644
> --- a/arch/x86/kernel/cpu/mshyperv.c
> +++ b/arch/x86/kernel/cpu/mshyperv.c
> @@ -565,6 +565,11 @@ static void __init ms_hyperv_init_platform(void)
>  	machine_ops.crash_shutdown = hv_machine_crash_shutdown;
>  #endif
>  #endif
> +	/*
> +	 * HV_ACCESS_TSC_INVARIANT is always zero for the root partition. Root
> +	 * partition doesn't need to write to synthetic MSR to enable invariant
> +	 * TSC feature. It sees what the hardware provides.
> +	 */
>  	if (ms_hyperv.features & HV_ACCESS_TSC_INVARIANT) {
>  		/*
>  		 * Writing to synthetic MSR 0x40000118 updates/changes the
> @@ -636,8 +641,12 @@ static void __init ms_hyperv_init_platform(void)
>  	 * TSC should be marked as unstable only after Hyper-V
>  	 * clocksource has been initialized. This ensures that the
>  	 * stability of the sched_clock is not altered.
> +	 *
> +	 * HV_ACCESS_TSC_INVARIANT is always zero for the root partition. No
> +	 * need to check for it.
>  	 */
> -	if (!(ms_hyperv.features & HV_ACCESS_TSC_INVARIANT))
> +	if (!hv_root_partition() &&
> +	    !(ms_hyperv.features & HV_ACCESS_TSC_INVARIANT))
>  		mark_tsc_unstable("running on Hyper-V");
>  
>  	hardlockup_detector_disable();
> diff --git a/drivers/clocksource/hyperv_timer.c b/drivers/clocksource/hyperv_timer.c
> index 2edc13ca184e..ca39044a4a60 100644
> --- a/drivers/clocksource/hyperv_timer.c
> +++ b/drivers/clocksource/hyperv_timer.c
> @@ -549,14 +549,22 @@ static void __init hv_init_tsc_clocksource(void)
>  	union hv_reference_tsc_msr tsc_msr;
>  
>  	/*
> +	 * When running as a guest partition:
> +	 *
>  	 * If Hyper-V offers TSC_INVARIANT, then the virtualized TSC correctly
>  	 * handles frequency and offset changes due to live migration,
>  	 * pause/resume, and other VM management operations.  So lower the
>  	 * Hyper-V Reference TSC rating, causing the generic TSC to be used.
>  	 * TSC_INVARIANT is not offered on ARM64, so the Hyper-V Reference
>  	 * TSC will be preferred over the virtualized ARM64 arch counter.
> +	 *
> +	 * When running as the root partition:
> +	 *
> +	 * There is no HV_ACCESS_TSC_INVARIANT feature. Skip the unnecessary
> +	 * check.
>  	 */
> -	if (ms_hyperv.features & HV_ACCESS_TSC_INVARIANT) {
> +	if ((ms_hyperv.features & HV_ACCESS_TSC_INVARIANT) ||
> +	    hv_root_partition()) {
>  		hyperv_cs_tsc.rating = 250;
>  		hyperv_cs_msr.rating = 245;
>  	}

Reviewed-by: Nuno Das Neves <nunodasneves@...ux.microsoft.com>