linux-kernel - Re: [PATCH v8 06/30] KVM: selftests: Add helper functions to create TDX VMs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <689bac9eb9b43_20a6d929445@iweiny-mobl.notmuch>
Date: Tue, 12 Aug 2025 16:05:34 -0500
From: Ira Weiny <ira.weiny@...el.com>
To: Sean Christopherson <seanjc@...gle.com>, Sagi Shahar <sagis@...gle.com>
CC: <linux-kselftest@...r.kernel.org>, Paolo Bonzini <pbonzini@...hat.com>,
	Shuah Khan <shuah@...nel.org>, Ackerley Tng <ackerleytng@...gle.com>, "Ryan
 Afranji" <afranji@...gle.com>, Andrew Jones <ajones@...tanamicro.com>, "Isaku
 Yamahata" <isaku.yamahata@...el.com>, Erdem Aktas <erdemaktas@...gle.com>,
	Rick Edgecombe <rick.p.edgecombe@...el.com>, Roger Wang
	<runanwang@...gle.com>, Binbin Wu <binbin.wu@...ux.intel.com>, Oliver Upton
	<oliver.upton@...ux.dev>, "Pratik R. Sampat" <pratikrajesh.sampat@....com>,
	Reinette Chatre <reinette.chatre@...el.com>, Ira Weiny <ira.weiny@...el.com>,
	<linux-kernel@...r.kernel.org>, <kvm@...r.kernel.org>
Subject: Re: [PATCH v8 06/30] KVM: selftests: Add helper functions to create
 TDX VMs

Sean Christopherson wrote:
> On Thu, Aug 07, 2025, Sagi Shahar wrote:
> > From: Erdem Aktas <erdemaktas@...gle.com>

[snip]

> > +
> > +static void load_td_memory_region(struct kvm_vm *vm,
> > +				  struct userspace_mem_region *region)
> > +{
> > +	const struct sparsebit *pages = region->protected_phy_pages;
> > +	const vm_paddr_t gpa_base = region->region.guest_phys_addr;
> > +	const uint64_t hva_base = region->region.userspace_addr;
> > +	const sparsebit_idx_t lowest_page_in_region = gpa_base >> vm->page_shift;
> > +
> > +	sparsebit_idx_t i;
> > +	sparsebit_idx_t j;
> > +
> > +	if (!sparsebit_any_set(pages))
> > +		return;
> > +
> > +	sparsebit_for_each_set_range(pages, i, j) {
> > +		const uint64_t size_to_load = (j - i + 1) * vm->page_size;
> > +		const uint64_t offset =
> > +			(i - lowest_page_in_region) * vm->page_size;
> > +		const uint64_t hva = hva_base + offset;
> > +		const uint64_t gpa = gpa_base + offset;
> > +		void *source_addr;
> > +
> > +		/*
> > +		 * KVM_TDX_INIT_MEM_REGION ioctl cannot encrypt memory in place.
> 
> We should really fix that.

I'm working on it.

This code will change with those changes.  But I'd like this to land, or
be close to landing, first.

Ira

[snip]