linux-kernel - Re: [PATCH 04/21] sh: select legacy gpiolib interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <e7128300-31f7-409f-9158-c5af915ed598@app.fastmail.com>
Date: Tue, 12 Aug 2025 23:28:31 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Rob Landley" <rob@...dley.net>, "Arnd Bergmann" <arnd@...nel.org>,
 "Bartosz Golaszewski" <brgl@...ev.pl>,
 "Linus Walleij" <linus.walleij@...aro.org>,
 "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
 "Yoshinori Sato" <ysato@...rs.sourceforge.jp>,
 "Rich Felker" <dalias@...c.org>,
 "John Paul Adrian Glaubitz" <glaubitz@...sik.fu-berlin.de>
Cc: "Michael Ellerman" <mpe@...erman.id.au>,
 "Steven Rostedt" <rostedt@...dmis.org>,
 "Paul E. McKenney" <paulmck@...nel.org>,
 "Masahiro Yamada" <masahiroy@...nel.org>,
 "Dave Vasilevsky" <dave@...ilevsky.ca>,
 "Geert Uytterhoeven" <geert+renesas@...der.be>, linux-sh@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/21] sh: select legacy gpiolib interface

On Tue, Aug 12, 2025, at 20:28, Rob Landley wrote:
> On 8/8/25 10:17, Arnd Bergmann wrote:
>> diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig
>> index d5795067befa..d60f1d5a94c0 100644
>> --- a/arch/sh/Kconfig
>> +++ b/arch/sh/Kconfig
>> @@ -462,6 +462,7 @@ config CPU_SUBTYPE_SHX3
>>   	select CPU_SHX3
>>   	select GENERIC_CLOCKEVENTS_BROADCAST if SMP
>>   	select GPIOLIB
>> +	select GPIOLIB_LEGACY
>>   	select PINCTRL
>
> Is there a reason to have both rather than having GPIOLIB_LEGACY select 
> GPIOLIB? (Does the legacy one ever NOT use the new one?)

The way I've staged the series was

1. add GPIOLIB_LEGACY as an always-enabled symbol in 6.17
2. add the 'select' and 'depends on' for that symbol in 6.18
3. turn it off for all configs that don't select it already

Having GPIOLIB_LEGACY select GPIOLIB does sound like a nice
idea in stage 3, but that doesn't work with the first step
that's already merged now.

      Arnd