linux-kernel - Re: [PATCH] soc/fsl/qbman: Use for_each_online_cpu() instead of for_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250812045642.54968-1-wangfushuai@baidu.com>
Date: Tue, 12 Aug 2025 12:56:42 +0800
From: Fushuai Wang <wangfushuai@...du.com>
To: <sshegde@...ux.ibm.com>
CC: <christophe.leroy@...roup.eu>, <frederic@...nel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
	<linuxppc-dev@...ts.ozlabs.org>, <wangfushuai@...du.com>
Subject: Re: [PATCH] soc/fsl/qbman: Use for_each_online_cpu() instead of for_each_cpu()

>> Replace the opencoded for_each_cpu(cpu, cpu_online_mask) loop with the
>> more readable and equivalent for_each_online_cpu(cpu) macro.
>> 
>> Signed-off-by: Fushuai Wang <wangfushuai@...du.com>
>> ---
>>   drivers/soc/fsl/qbman/qman_test_stash.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/soc/fsl/qbman/qman_test_stash.c b/drivers/soc/fsl/qbman/qman_test_stash.c
>> index f4d3c2146f4f..6f7597950aa3 100644
>> --- a/drivers/soc/fsl/qbman/qman_test_stash.c
>> +++ b/drivers/soc/fsl/qbman/qman_test_stash.c
>> @@ -103,7 +103,7 @@ static int on_all_cpus(int (*fn)(void))
>>   {
>>   	int cpu;
>>   
>> -	for_each_cpu(cpu, cpu_online_mask) {
>> +	for_each_online_cpu(cpu) {
>>   		struct bstrap bstrap = {
>>   			.fn = fn,
>>   			.started = ATOMIC_INIT(0)
> 
> Yes. This change makes sense given that for_each_online_cpu expands into the same.
> 
> Why not do for the remaining ones too?

I’m working on updating the remaining instances as well.
To keep the commits clear, I’m sending separate patches for each file/subsystem.

Regards,
Wang.

> linux_tip$ grep -Rw "for_each_cpu" * | grep  cpu_online_mask
> arch/riscv/kernel/unaligned_access_speed.c:     for_each_cpu(cpu, cpu_online_mask) {
> arch/riscv/kernel/unaligned_access_speed.c:     for_each_cpu(cpu, cpu_online_mask) {
> drivers/soc/fsl/qbman/qman_test_stash.c:        for_each_cpu(cpu, cpu_online_mask) {    ** current patch addresses this.
> drivers/infiniband/hw/hfi1/sdma.c:      for_each_cpu(cpu, cpu_online_mask) {
> drivers/cpuidle/cpuidle-tegra.c:        for_each_cpu(lcpu, cpu_online_mask) {
> include/rv/da_monitor.h:        for_each_cpu(cpu, cpu_online_mask) {
> kernel/trace/trace_osnoise.c:   for_each_cpu(cpu, cpu_online_mask) {
> kernel/trace/trace_osnoise.c:   for_each_cpu(cpu, cpu_online_mask) {
> 
> 
> Rest everyone seems to have moved.
> linux_tip$ grep -Rw "for_each_online_cpu" * | wc
>      416    1141   23047