linux-kernel - Re: [PATCH] clk: thead: Correct parent for DPU pixel clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aJrLI7RAAUBTgiEK@x1>
Date: Mon, 11 Aug 2025 22:03:31 -0700
From: Drew Fustini <fustini@...nel.org>
To: Michal Wilczynski <m.wilczynski@...sung.com>
Cc: Guo Ren <guoren@...nel.org>, Fu Wei <wefu@...hat.com>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...nel.org>, linux-riscv@...ts.infradead.org,
	linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
	Icenowy Zheng <uwu@...nowy.me>
Subject: Re: [PATCH] clk: thead: Correct parent for DPU pixel clocks

On Sat, Aug 09, 2025 at 07:02:00PM +0200, Michal Wilczynski wrote:
> The dpu0_pixelclk and dpu1_pixelclk gates were incorrectly parented to
> the video_pll_clk.
> 
> According to the TH1520 TRM, the "dpu0_pixelclk" should be sourced from
> "DPU0 PLL DIV CLK". In this driver, "DPU0 PLL DIV CLK" corresponds to
> the `dpu0_clk` clock, which is a divider whose parent is the
> `dpu0_pll_clk`.
> 
> This patch corrects the clock hierarchy by reparenting `dpu0_pixelclk`
> to `dpu0_clk`. By symmetry, `dpu1_pixelclk` is also reparented to its
> correct source, `dpu1_clk`.
> 
> Fixes: 50d4b157fa96 ("clk: thead: Add clock support for VO subsystem in T-HEAD TH1520 SoC")
> Reported-by: Icenowy Zheng <uwu@...nowy.me>
> Signed-off-by: Michal Wilczynski <m.wilczynski@...sung.com>

Reviewed-by: Drew Fustini <fustini@...nel.org>

Thanks for the patch. I've been excited to see Icenowy and you working
on the graphics functionality.

-Drew