linux-kernel - Re: [PATCH v1 0/2] mm: remove MIGRATEPAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bjolgwe3.fsf@DESKTOP-5N7EMDA>
Date: Tue, 12 Aug 2025 09:29:40 +0800
From: "Huang, Ying" <ying.huang@...ux.alibaba.com>
To: David Hildenbrand <david@...hat.com>
Cc: linux-kernel@...r.kernel.org,  linux-mm@...ck.org,
  linuxppc-dev@...ts.ozlabs.org,  virtualization@...ts.linux.dev,
  linux-fsdevel@...r.kernel.org,  linux-aio@...ck.org,
  linux-btrfs@...r.kernel.org,  jfs-discussion@...ts.sourceforge.net,
  Andrew Morton <akpm@...ux-foundation.org>,  Madhavan Srinivasan
 <maddy@...ux.ibm.com>,  Michael Ellerman <mpe@...erman.id.au>,  Nicholas
 Piggin <npiggin@...il.com>,  Christophe Leroy
 <christophe.leroy@...roup.eu>,  Jerrin Shaji George
 <jerrin.shaji-george@...adcom.com>,  Arnd Bergmann <arnd@...db.de>,  Greg
 Kroah-Hartman <gregkh@...uxfoundation.org>,  "Michael S. Tsirkin"
 <mst@...hat.com>,  Jason Wang <jasowang@...hat.com>,  Xuan Zhuo
 <xuanzhuo@...ux.alibaba.com>,  Eugenio Pérez
 <eperezma@...hat.com>,
  Alexander Viro <viro@...iv.linux.org.uk>,  Christian Brauner
 <brauner@...nel.org>,  Jan Kara <jack@...e.cz>,  Benjamin LaHaise
 <bcrl@...ck.org>,  Chris Mason <clm@...com>,  Josef Bacik
 <josef@...icpanda.com>,  David Sterba <dsterba@...e.com>,  Muchun Song
 <muchun.song@...ux.dev>,  Oscar Salvador <osalvador@...e.de>,  Dave
 Kleikamp <shaggy@...nel.org>,  Zi Yan <ziy@...dia.com>,  Matthew Brost
 <matthew.brost@...el.com>,  Joshua Hahn <joshua.hahnjy@...il.com>,  Rakie
 Kim <rakie.kim@...com>,  Byungchul Park <byungchul@...com>,  Gregory Price
 <gourry@...rry.net>,  Alistair Popple <apopple@...dia.com>,  Minchan Kim
 <minchan@...nel.org>,  Sergey Senozhatsky <senozhatsky@...omium.org>
Subject: Re: [PATCH v1 0/2] mm: remove MIGRATEPAGE_*

Hi, David,

David Hildenbrand <david@...hat.com> writes:

> This is against mm/mm-new.
>
> This series gets rid of MIGRATEPAGE_UNMAP, to then convert the remaining
> MIGRATEPAGE_SUCCESS usage to simply use 0 instead.
>
> Not sure if it makes sense to split the second patch up, a treewide
> cleanup felt more reasonable for this simple change in an area where
> I don't expect a lot of churn.
>
> Briefly tested with virtio-mem in a VM, making sure that basic
> page migration keeps working.
>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Madhavan Srinivasan <maddy@...ux.ibm.com>
> Cc: Michael Ellerman <mpe@...erman.id.au>
> Cc: Nicholas Piggin <npiggin@...il.com>
> Cc: Christophe Leroy <christophe.leroy@...roup.eu>
> Cc: Jerrin Shaji George <jerrin.shaji-george@...adcom.com>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: "Michael S. Tsirkin" <mst@...hat.com>
> Cc: Jason Wang <jasowang@...hat.com>
> Cc: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
> Cc: "Eugenio Pérez" <eperezma@...hat.com>
> Cc: Alexander Viro <viro@...iv.linux.org.uk>
> Cc: Christian Brauner <brauner@...nel.org>
> Cc: Jan Kara <jack@...e.cz>
> Cc: Benjamin LaHaise <bcrl@...ck.org>
> Cc: Chris Mason <clm@...com>
> Cc: Josef Bacik <josef@...icpanda.com>
> Cc: David Sterba <dsterba@...e.com>
> Cc: Muchun Song <muchun.song@...ux.dev>
> Cc: Oscar Salvador <osalvador@...e.de>
> Cc: Dave Kleikamp <shaggy@...nel.org>
> Cc: Zi Yan <ziy@...dia.com>
> Cc: Matthew Brost <matthew.brost@...el.com>
> Cc: Joshua Hahn <joshua.hahnjy@...il.com>
> Cc: Rakie Kim <rakie.kim@...com>
> Cc: Byungchul Park <byungchul@...com>
> Cc: Gregory Price <gourry@...rry.net>
> Cc: Ying Huang <ying.huang@...ux.alibaba.com>
> Cc: Alistair Popple <apopple@...dia.com>
> Cc: Minchan Kim <minchan@...nel.org>
> Cc: Sergey Senozhatsky <senozhatsky@...omium.org>
>
> David Hildenbrand (2):
>   mm/migrate: remove MIGRATEPAGE_UNMAP
>   treewide: remove MIGRATEPAGE_SUCCESS

LGTM.  Feel free to add my

Reviewed-by: Huang Ying <ying.huang@...ux.alibaba.com>

for the whole series in the future versions.

>  arch/powerpc/platforms/pseries/cmm.c |  2 +-
>  drivers/misc/vmw_balloon.c           |  4 +-
>  drivers/virtio/virtio_balloon.c      |  2 +-
>  fs/aio.c                             |  2 +-
>  fs/btrfs/inode.c                     |  4 +-
>  fs/hugetlbfs/inode.c                 |  4 +-
>  fs/jfs/jfs_metapage.c                |  8 +--
>  include/linux/migrate.h              | 11 +---
>  mm/migrate.c                         | 80 ++++++++++++++--------------
>  mm/migrate_device.c                  |  2 +-
>  mm/zsmalloc.c                        |  4 +-
>  11 files changed, 56 insertions(+), 67 deletions(-)
>
>
> base-commit: 53c448023185717d0ed56b5546dc2be405da92ff

---
Best Regards,
Huang, Ying