linux-kernel - Re: [PATCH v3 06/12] dt-bindings: PCI: Split exynos host into two files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4a47b758-5c20-4e30-bc61-206acd48bdd0@kernel.org>
Date: Tue, 12 Aug 2025 08:32:03 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Shradha Todi <shradha.t@...sung.com>, linux-pci@...r.kernel.org,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-phy@...ts.infradead.org
Cc: mani@...nel.org, lpieralisi@...nel.org, kwilczynski@...nel.org,
 robh@...nel.org, bhelgaas@...gle.com, jingoohan1@...il.com,
 krzk+dt@...nel.org, conor+dt@...nel.org, alim.akhtar@...sung.com,
 vkoul@...nel.org, kishon@...nel.org, arnd@...db.de,
 m.szyprowski@...sung.com, jh80.chung@...sung.com, pankaj.dubey@...sung.com
Subject: Re: [PATCH v3 06/12] dt-bindings: PCI: Split exynos host into two
 files

On 11/08/2025 17:46, Shradha Todi wrote:
> The current Exynos PCIe yaml binding file is hard to reuse by
> other Samsung SoCs. Refactoring it by:
>  - Moving common Samsung PCIe properties into samsung,exynos-pcie.yaml
>  - Creating a dedicated samsung,exynos5433-pcie.yaml file for properties
>    and constraints specific to the Exynos5433 SoC
> 
> Signed-off-by: Shradha Todi <shradha.t@...sung.com>
> ---
>  .../bindings/pci/samsung,exynos-pcie.yaml     | 70 +--------------
>  .../bindings/pci/samsung,exynos5433-pcie.yaml | 89 +++++++++++++++++++
>  2 files changed, 91 insertions(+), 68 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/pci/samsung,exynos5433-pcie.yaml
> 
> diff --git a/Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml b/Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml
> index f20ed7e709f7..fd0b97b30821 100644
> --- a/Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml
> @@ -11,7 +11,7 @@ maintainers:
>    - Jaehoon Chung <jh80.chung@...sung.com>
>  
>  description: |+
> -  Exynos5433 SoC PCIe host controller is based on the Synopsys DesignWare
> +  Samsung SoCs PCIe host controller is based on the Synopsys DesignWare
>    PCIe IP and thus inherits all the common properties defined in
>    snps,dw-pcie.yaml.
>  
> @@ -19,9 +19,6 @@ allOf:
>    - $ref: /schemas/pci/snps,dw-pcie.yaml#
>  
>  properties:
> -  compatible:
> -    const: samsung,exynos5433-pcie
> -
>    reg:
>      items:
>        - description: Data Bus Interface (DBI) registers.


So the only common part left here is reg and phy? I don't think such
common file brings any value.


Best regards,
Krzysztof