linux-kernel - Re: [PATCH v5 3/7] x86/virt/tdx: Mark memory cache state incoherent when making SEAMCALL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e11de78443cea475030635b4d440803db3e0cf8c.camel@intel.com>
Date: Tue, 12 Aug 2025 01:34:35 +0000
From: "Edgecombe, Rick P" <rick.p.edgecombe@...el.com>
To: "Hansen, Dave" <dave.hansen@...el.com>, "bp@...en8.de" <bp@...en8.de>,
	"Huang, Kai" <kai.huang@...el.com>, "peterz@...radead.org"
	<peterz@...radead.org>, "hpa@...or.com" <hpa@...or.com>, "mingo@...hat.com"
	<mingo@...hat.com>, "thomas.lendacky@....com" <thomas.lendacky@....com>,
	"tglx@...utronix.de" <tglx@...utronix.de>
CC: "Gao, Chao" <chao.gao@...el.com>, "Yamahata, Isaku"
	<isaku.yamahata@...el.com>, "seanjc@...gle.com" <seanjc@...gle.com>,
	"x86@...nel.org" <x86@...nel.org>, "kas@...nel.org" <kas@...nel.org>,
	"sagis@...gle.com" <sagis@...gle.com>, "Chatre, Reinette"
	<reinette.chatre@...el.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "Williams, Dan J" <dan.j.williams@...el.com>,
	"Chen, Farrah" <farrah.chen@...el.com>, "ashish.kalra@....com"
	<ashish.kalra@....com>, "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
	"nik.borisov@...e.com" <nik.borisov@...e.com>, "dwmw@...zon.co.uk"
	<dwmw@...zon.co.uk>, "pbonzini@...hat.com" <pbonzini@...hat.com>
Subject: Re: [PATCH v5 3/7] x86/virt/tdx: Mark memory cache state incoherent
 when making SEAMCALL

On Tue, 2025-08-12 at 01:32 +0000, Huang, Kai wrote:
> > sc_retry() is the only one with a hint of what is different about it, but it
> > randomly uses sc abbreviation instead of seamcall. That is an existing
> > thing.
> > But the additional one should be named with something about the cache part
> > that
> > it does, like seamcall_dirty_cache() or something. "do_seamcall()" tells the
> > reader nothing.
> 
> OK. I'll change do_seamcall() to seamcall_dirty_cache().
> 
> Is there anything else I can improve?  Otherwise I plan to send out v6
> soon.

I do think we should look at improving the stack of seamcall helpers. But
otherwise, please add:

Reviewed-by: Rick Edgecombe <rick.p.edgecombe@...el.com> with the name change.