linux-kernel - Re: [PATCH 1/7] ALSA: usb-audio: Add initial driver for TASCAM US-144MKII

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87v7mtyrcy.wl-tiwai@suse.de>
Date: Tue, 12 Aug 2025 08:41:01 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Šerif Rami <ramiserifpersia@...il.com>
Cc: Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/7] ALSA: usb-audio: Add initial driver for TASCAM US-144MKII

On Sun, 10 Aug 2025 14:49:52 +0200,
Šerif Rami wrote:
> 
> +static int tascam_probe(struct usb_interface *intf,
> +			const struct usb_device_id *usb_id)
> +{
> +	struct usb_device *dev = interface_to_usbdev(intf);
> +	struct snd_card *card;
> +	struct tascam_card *tascam;
> +	int err;
> +

Please drop a blank line.

> +	char *handshake_buf __free(kfree);

For the __free(kfree), you'd always need to initialize the variable to
NULL, i.e.
	char *handshake_buf __free(kfree) = NULL;

> +/**
> + * struct tascam_card - Driver data structure for TASCAM US-144MKII.
> + * @dev: Pointer to the USB device.
> + * @iface0: Pointer to USB interface 0 (audio).
> + * @iface1: Pointer to USB interface 1 (MIDI).
> + * @card: Pointer to the ALSA sound card instance.
> + */
> +struct tascam_card {
> +struct usb_device *dev;
> +struct usb_interface *iface0;
> +struct usb_interface *iface1;
> +struct snd_card *card;
> +};

I see you fix the indentation in a later patch, but better to have the
right indentation from the beginning.


thanks,

Takashi