linux-kernel - Re: [PATCH] squashfs: Avoid mem leak in squashfs_fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aJr43n1np2nB8bht@stanley.mountain>
Date: Tue, 12 Aug 2025 11:18:38 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Scott Guo <scott_gzh@....com>
Cc: Markus Elfring <Markus.Elfring@....de>,
	Scott Guo <scottzhguo@...cent.com>,
	Phillip Lougher <phillip@...ashfs.org.uk>,
	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] squashfs: Avoid mem leak in squashfs_fill_super

On Tue, Aug 12, 2025 at 10:11:21AM +0800, Scott Guo wrote:
> > 
> > By the way:
> > I propose to refine the goto chain by using additional labels like “e_inval” and “e_nomem”
> > so that another bit of exception handling code can be shared at the end
> > of this function implementation.
> > https://elixir.bootlin.com/linux/v6.16/source/fs/squashfs/super.c#L434-L466
> Will have a look into that, but maybe fix the current issue first.>

Please, don't introduce more of those e_inval, e_nomem labels.

regards,
dan carpenter