linux-kernel - Re: [PATCH] rust: auxiliary: Use `c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025081245-chubby-strep-1181@gregkh>
Date: Tue, 12 Aug 2025 10:27:57 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Abhinav Ananthu <abhinav.ogl@...il.com>
Cc: david.m.ertman@...el.com, ira.weiny@...el.com, leon@...nel.org,
	ojeda@...nel.org, alex.gaynor@...il.com, boqun.feng@...il.com,
	gary@...yguo.net, bjorn3_gh@...tonmail.com, lossin@...nel.org,
	a.hindborg@...nel.org, aliceryhl@...gle.com, tmgross@...ch.edu,
	dakr@...nel.org, rust-for-linux@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rust: auxiliary: Use `c_` types from prelude instead of

On Tue, Aug 12, 2025 at 01:21:10PM +0530, Abhinav Ananthu wrote:
> Update auxiliary FFI callback signatures to reference the `c_` types
> provided by the kernel prelude, rather than accessing them via
> `kernel::ffi::`.
> 
> Signed-off-by: Abhinav Ananthu <abhinav.ogl@...il.com>
> ---
>  rust/kernel/auxiliary.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/rust/kernel/auxiliary.rs b/rust/kernel/auxiliary.rs
> index d2cfe1eeefb6..030e31333689 100644
> --- a/rust/kernel/auxiliary.rs
> +++ b/rust/kernel/auxiliary.rs
> @@ -56,7 +56,7 @@ impl<T: Driver + 'static> Adapter<T> {
>      extern "C" fn probe_callback(
>          adev: *mut bindings::auxiliary_device,
>          id: *const bindings::auxiliary_device_id,
> -    ) -> kernel::ffi::c_int {
> +    ) -> c_int {
>          // SAFETY: The auxiliary bus only ever calls the probe callback with a valid pointer to a
>          // `struct auxiliary_device`.
>          //
> -- 
> 2.34.1
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot