linux-kernel - Re: [PATCH 2/3] soc: qcom: mdt_loader: Remove pas id parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3bbd8fe7-2792-474b-ab5e-f458bcf13dc3@kernel.org>
Date: Tue, 12 Aug 2025 10:31:12 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Dikshita Agarwal <quic_dikshita@...cinc.com>,
 Mukesh Ojha <mukesh.ojha@....qualcomm.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>,
 Vikash Garodia <quic_vgarodia@...cinc.com>,
 Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Jeff Johnson <jjohnson@...nel.org>,
 Mathieu Poirier <mathieu.poirier@...aro.org>,
 Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Cc: linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-media@...r.kernel.org, linux-wireless@...r.kernel.org,
 ath12k@...ts.infradead.org, linux-remoteproc@...r.kernel.org,
 Bjorn Andersson <bjorn.andersson@....qualcomm.com>
Subject: Re: [PATCH 2/3] soc: qcom: mdt_loader: Remove pas id parameter

On 06/08/2025 09:25, Dikshita Agarwal wrote:
> 
> 
> On 8/4/2025 6:11 PM, Mukesh Ojha wrote:
>> pas id is not used in qcom_mdt_load_no_init() and it should not
>> be used as it is non-PAS specific function and has no relation
>> to PAS specific mechanism.
>>
>> Signed-off-by: Mukesh Ojha <mukesh.ojha@....qualcomm.com>
>> ---
>>  drivers/media/platform/qcom/venus/firmware.c |  4 ++--
>>  drivers/net/wireless/ath/ath12k/ahb.c        |  2 +-
>>  drivers/remoteproc/qcom_q6v5_adsp.c          |  2 +-
>>  drivers/remoteproc/qcom_q6v5_pas.c           |  7 +++----
>>  drivers/remoteproc/qcom_q6v5_wcss.c          |  2 +-
>>  drivers/soc/qcom/mdt_loader.c                | 14 ++++++--------
>>  include/linux/soc/qcom/mdt_loader.h          |  7 +++----
>>  7 files changed, 17 insertions(+), 21 deletions(-)
>>
>> diff --git a/drivers/media/platform/qcom/venus/firmware.c b/drivers/media/platform/qcom/venus/firmware.c
>> index 66a18830e66d..862d0718f694 100644
>> --- a/drivers/media/platform/qcom/venus/firmware.c
>> +++ b/drivers/media/platform/qcom/venus/firmware.c
>> @@ -136,8 +136,8 @@ static int venus_load_fw(struct venus_core *core, const char *fwname,
>>  		ret = qcom_mdt_load(dev, mdt, fwname, VENUS_PAS_ID,
>>  				    mem_va, *mem_phys, *mem_size, NULL);
>>  	else
>> -		ret = qcom_mdt_load_no_init(dev, mdt, fwname, VENUS_PAS_ID,
>> -					    mem_va, *mem_phys, *mem_size, NULL);
>> +		ret = qcom_mdt_load_no_init(dev, mdt, fwname, mem_va,
>> +					    *mem_phys, *mem_size, NULL);
>>  
>>  	memunmap(mem_va);
>>  err_release_fw:
> 
> Reviewed-by: Dikshita Agarwal <quic_dikshita@...cinc.com>

You wanted Acked tag for reviewing that one, trivial line. Adding entire
review for entire commit just after looking at trivial change is not
really justified.

See also submitting patches about reviewer's statement of oversight.

Best regards,
Krzysztof