linux-kernel - Re: [PATCH] perf parse-events: Fix potential null pointer dereference in __add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2d1c8222-cfc6-40e1-b26e-9cb1adc90202@web.de>
Date: Tue, 12 Aug 2025 11:22:43 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: GuoHan Zhao <zhaoguohan@...inos.cn>, linux-perf-users@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>,
 Adrian Hunter <adrian.hunter@...el.com>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Arnaldo Carvalho de Melo <acme@...nel.org>, Ian Rogers <irogers@...gle.com>,
 Ingo Molnar <mingo@...hat.com>, Jiri Olsa <jolsa@...nel.org>,
 Kan Liang <kan.liang@...ux.intel.com>, Mark Rutland <mark.rutland@....com>,
 Namhyung Kim <namhyung@...nel.org>, Peter Zijlstra <peterz@...radead.org>,
 Thomas Falcon <thomas.falcon@...el.com>
Subject: Re: [PATCH] perf parse-events: Fix potential null pointer dereference
 in __add_event()

…
> Add a null check before accessing evsel members in the error path.

* Please extend the goto chain instead for better exception handling.
  You may reorder jump targets accordingly.

* How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?

* Would a summary phrase like “Prevent null pointer dereference in __add_event()”
  be nicer?


Regards,
Markus