linux-kernel - Re: [PATCH] dt-bindings: powerpc: Drop duplicate fsl/mpic.txt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aJr-d1tZREOY6U5a@buserror.net>
Date: Tue, 12 Aug 2025 03:42:31 -0500
From: Crystal Wood <oss@...error.net>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: Thomas Gleixner <tglx@...utronix.de>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Madhavan Srinivasan <maddy@...ux.ibm.com>,
	Michael Ellerman <mpe@...erman.id.au>,
	Nicholas Piggin <npiggin@...il.com>,
	Christophe Leroy <christophe.leroy@...roup.eu>,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH] dt-bindings: powerpc: Drop duplicate fsl/mpic.txt

On Thu, Aug 07, 2025 at 04:44:30PM -0500, Rob Herring (Arm) wrote:
> The chrp,open-pic binding schema already supports the "fsl,mpic"
> compatible. A couple of properties are missing, so add them and remove
> fsl/mpic.txt.
> 
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>

What about the 4-cell interrupt specifiers?

> -                  0 = external or normal SoC device interrupt
> -
> -                      The interrupt-number cell contains
> -                      the SoC device interrupt number.  The
> -                      type-specific cell is undefined.  The
> -                      interrupt-number is derived from the
> -                      MPIC a block of registers referred to as
> -                      the "Interrupt Source Configuration Registers".
> -                      Each source has 32-bytes of registers
> -                      (vector/priority and destination) in this
> -                      region.   So interrupt 0 is at offset 0x0,
> -                      interrupt 1 is at offset 0x20, and so on.

FWIW, while this description may seem unnecessarily verbose, it's because
it's different from how Freescale hardware docs numbered the IRQs
(IRQ 16 was "internal IRQ 0", etc).

-Crystal