linux-kernel - Re: [PATCH] squashfs: Avoid mem leak in squashfs_fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <461ae944-5fb9-4860-81c1-1ac48c3d888f@163.com>
Date: Tue, 12 Aug 2025 10:11:21 +0800
From: Scott Guo <scott_gzh@....com>
To: Markus Elfring <Markus.Elfring@....de>, Scott Guo
 <scottzhguo@...cent.com>, Phillip Lougher <phillip@...ashfs.org.uk>
Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] squashfs: Avoid mem leak in squashfs_fill_super

Hi Markus,

在 2025/8/11 15:02, Markus Elfring 写道:
>> If sb_min_blocksize returns 0, -EINVAL was returned without freeing
>> sb->s_fs_info, causing mem leak.
> 
>                           memory?
> 
> 
> How do you think about to append parentheses to the function name (in the summary phrase)?
Sure, will do that in V2.>
> 
>> Fix it by goto failed_mount.
> 
> By the way:
> I propose to refine the goto chain by using additional labels like “e_inval” and “e_nomem”
> so that another bit of exception handling code can be shared at the end
> of this function implementation.
> https://elixir.bootlin.com/linux/v6.16/source/fs/squashfs/super.c#L434-L466
Will have a look into that, but maybe fix the current issue first.>
> Regards,
> Markus