linux-kernel - Re: [PATCH] phy: qualcomm: phy-qcom-eusb2-repeater: fix override properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DC0DBER6477Q.143SU9KXEI6FN@fairphone.com>
Date: Tue, 12 Aug 2025 12:13:39 +0200
From: "Luca Weiss" <luca.weiss@...rphone.com>
To: "Pengyu Luo" <mitltlatltl@...il.com>, "Vinod Koul" <vkoul@...nel.org>,
 "Kishon Vijay Abraham I" <kishon@...nel.org>, "Dmitry Baryshkov"
 <dmitry.baryshkov@....qualcomm.com>, "Neil Armstrong"
 <neil.armstrong@...aro.org>, "Konrad Dybcio"
 <konrad.dybcio@....qualcomm.com>, "Abel Vesa" <abel.vesa@...aro.org>
Cc: <linux-arm-msm@...r.kernel.org>, <linux-phy@...ts.infradead.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] phy: qualcomm: phy-qcom-eusb2-repeater: fix override
 properties

On Tue Aug 12, 2025 at 11:39 AM CEST, Pengyu Luo wrote:
> property "qcom,tune-usb2-preem" is for EUSB2_TUNE_USB2_PREEM
> property "qcom,tune-usb2-amplitude" is for EUSB2_TUNE_IUSB2
>
> The downstream correspondence is as follows:
> EUSB2_TUNE_USB2_PREEM: Tx pre-emphasis tuning
> EUSB2_TUNE_IUSB2: HS trasmit amplitude
> EUSB2_TUNE_SQUELCH_U: Squelch detection threshold
> EUSB2_TUNE_HSDISC: HS disconnect threshold
> EUSB2_TUNE_EUSB_SLEW: slew rate
>
> Fixes: 31bc94de7602 ("phy: qualcomm: phy-qcom-eusb2-repeater: Don't zero-out registers")

Oh, not sure how this happened. Thanks for catching this, I do see the
problem in my original commit.

Reviewed-by: Luca Weiss <luca.weiss@...rphone.com>

Regards
Luca

> Signed-off-by: Pengyu Luo <mitltlatltl@...il.com>
> ---
>  drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c b/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c
> index d7493c229..3709fba42 100644
> --- a/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c
> +++ b/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c
> @@ -127,13 +127,13 @@ static int eusb2_repeater_init(struct phy *phy)
>  			     rptr->cfg->init_tbl[i].value);
>  
>  	/* Override registers from devicetree values */
> -	if (!of_property_read_u8(np, "qcom,tune-usb2-amplitude", &val))
> +	if (!of_property_read_u8(np, "qcom,tune-usb2-preem", &val))
>  		regmap_write(regmap, base + EUSB2_TUNE_USB2_PREEM, val);
>  
>  	if (!of_property_read_u8(np, "qcom,tune-usb2-disc-thres", &val))
>  		regmap_write(regmap, base + EUSB2_TUNE_HSDISC, val);
>  
> -	if (!of_property_read_u8(np, "qcom,tune-usb2-preem", &val))
> +	if (!of_property_read_u8(np, "qcom,tune-usb2-amplitude", &val))
>  		regmap_write(regmap, base + EUSB2_TUNE_IUSB2, val);
>  
>  	/* Wait for status OK */