linux-kernel - Re: [PATCH] sched/deadline: Fix dl_server

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAhV-H5TPNJur6Puebo6Y-FpkXu73-5eC68vXHm2zFibDiP0AQ@mail.gmail.com>
Date: Tue, 12 Aug 2025 18:21:54 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: Juri Lelli <juri.lelli@...hat.com>
Cc: Huacai Chen <chenhuacai@...ngson.cn>, Ingo Molnar <mingo@...hat.com>, 
	Peter Zijlstra <peterz@...radead.org>, Vincent Guittot <vincent.guittot@...aro.org>, 
	Dietmar Eggemann <dietmar.eggemann@....com>, Steven Rostedt <rostedt@...dmis.org>, 
	Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched/deadline: Fix dl_server_stopped()

On Tue, Aug 12, 2025 at 5:19 PM Juri Lelli <juri.lelli@...hat.com> wrote:
>
> Hi,
>
> On 09/08/25 21:04, Huacai Chen wrote:
> > Commit cccb45d7c429 ("sched/deadline: Less agressive dl_server handling")
> > introduces dl_server_stopped(). But it is obvious that dl_server_stopped()
> > should return true if dl_se->dl_server_active is 0.
> >
> > Fixes: cccb45d7c429 ("sched/deadline: Less agressive dl_server handling")
> > Signed-off-by: Huacai Chen <chenhuacai@...ngson.cn>
>
> This looks correct.
>
> Acked-by: Juri Lelli <juri.lelli@...hat.com>
>
> > ---
> > I found that after commit cccb45d7c429 ("sched/deadline: Less agressive
> > dl_server handling") there is always a message "sched: DL replenish lagged
> > too much" after boot. Then I found this bug, but unfortunately this patch
> > cannot wipe the message.
>
> Does
>
> https://lore.kernel.org/lkml/20250615131129.954975-1-kuyo.chang@mediatek.com/
>
> help with the issue?
Yes, this patch can solve my problem.

Huacai

>
> Thanks,
> Juri
>