lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250812102345.GAaJsWMTNvC2ULKtep@fat_crate.local>
Date: Tue, 12 Aug 2025 12:23:45 +0200
From: Borislav Petkov <bp@...en8.de>
To: Sohil Mehta <sohil.mehta@...el.com>
Cc: Borislav Petkov <bp@...nel.org>, X86 ML <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] x86/microcode: Add microcode= cmdline parsing

On Mon, Aug 11, 2025 at 07:26:59PM -0700, Sohil Mehta wrote:
> How about adding something like this to encourage using the new options:
> 
> 
> @@ -1211,7 +1211,7 @@
> 
> -       dis_ucode_ldr   [X86] Disable the microcode loader.
> +       dis_ucode_ldr   [X86] Same as microcode=disable_loader.
> 
> 
> @@ -3770,6 +3770,9 @@
> 
> +                       disable_loader
> +                               Disable the microcode loader.

Because adding a new alias of a cmdline parameter doesn't belong in the same
patch.

And if anything, that thing should be

	microcode=off

to save me some silly typing.

> Unnecessary whitespace added before tab.

Pff.

> Setting this to "false" is redundant.

Fixed.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ