linux-kernel - Re: [PATCH 6.6] gfs2: replace sd_aspace with sd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025081207-thermos-secret-ce3a@gregkh>
Date: Tue, 12 Aug 2025 12:50:26 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Sumanth Gavini <sumanth.gavini@...oo.com>
Cc: rpeterso@...hat.com, agruenba@...hat.com, gfs2@...ts.linux.dev,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH 6.6] gfs2: replace sd_aspace with sd_inode

On Tue, Aug 05, 2025 at 02:40:04PM -0500, Sumanth Gavini wrote:
> commit ae9f3bd8259a0a8f67be2420e66bb05fbb95af48 upstream.
> 
> Currently, sdp->sd_aspace and the per-inode metadata address spaces use
> sb->s_bdev->bd_mapping->host as their ->host; folios in those address
> spaces will thus appear to be on bdev rather than on gfs2 filesystems.
> This is a problem because gfs2 doesn't support cgroup writeback
> (SB_I_CGROUPWB), but bdev does.
> 
> Fix that by using a "dummy" gfs2 inode as ->host in those address
> spaces.  When coming from a folio, folio->mapping->host->i_sb will then
> be a gfs2 super block and the SB_I_CGROUPWB flag will not be set in
> sb->s_iflags.
> 
> Based on a previous version from Bob Peterson from several years ago.
> Thanks to Tetsuo Handa, Jan Kara, and Rafael Aquini for helping figure
> this out.
> 
> Fixes: aaa2cacf8184 ("writeback: add lockdep annotation to inode_to_wb()")
> Signed-off-by: Andreas Gruenbacher <agruenba@...hat.com>
> Signed-off-by: Sumanth Gavini <sumanth.gavini@...oo.com>
> ---

This is very different from the original commit and you did not document
that :(

Please fix up and resend.

thanks,

greg k-h