linux-kernel - Re: [PATCH 2/3] arm64: dts: ti: k3-am62x-sk-common: Remove the unused config from USB1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250813131530.apibc4p6t2uo5bkr@lcpd911>
Date: Wed, 13 Aug 2025 18:45:30 +0530
From: Dhruva Gole <d-gole@...com>
To: Akashdeep Kaur <a-kaur@...com>
CC: <vigneshr@...com>, <praneeth@...com>, <nm@...com>, <afd@...com>,
        <kristo@...nel.org>, <robh@...nel.org>, <krzk+dt@...nel.org>,
        <conor+dt@...nel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <vishalm@...com>, <sebin.francis@...com>
Subject: Re: [PATCH 2/3] arm64: dts: ti: k3-am62x-sk-common: Remove the
 unused config from USB1_DRVVBUS

On Jul 31, 2025 at 17:26:30 +0530, Akashdeep Kaur wrote:
> After the SoC has entered the Deep Sleep mode, USB1 can be used to wakeup

Just leaving my comments on the commit message here since 1st patch
seems to be pretty much the same commit message.

Let's reword this as --> Deep Sleep low power mode.
Makes it a bit more clear.

> the SoC based on USB events triggered by USB devices. This requires that
> the pin corresponding to the Type-A connector remains pulled up even after
> the SoC has entered the Deep Sleep mode.
> For that, either deep Sleep pullup can be selected or the pin can have the

Nit: Be consistent with either deep sleep, or Deep Sleep, don't mix case.
Also, please can we talk here in terms of exactly which macros we're
talking about? For eg. if deep sleep pullup == PIN_DS_PULLUD_ENABLE, then
please mention that in a bracket or something for people who may not
necessarily be aware of all these terms.

> same configuration that it had when SoC was in active mode.
> In order for deep sleep configuration to take effect, the deep sleep
> control bit has to be enabled.

Please talk with some references, because not everyone will be able to
follow what we mean by deep sleep control bit/ deep sleep configuration.

> Remove the deep sleep state configuration from USB1_DRVBUS pin as it is
> anyways not taking effect (deep sleep control bit is not set).
> 
> This reverts commit 527f884d2d94981016e181dcbd4c4b5bf597c0ad.

And so are you in conclusion saying that this patch is just unnecessary/
useless? The bracket message feels to me that you are saying that if we set
the deep sleep control bit this patch will start working as expected?
Please can you clarify a bit on that end?

> 
> Signed-off-by: Akashdeep Kaur <a-kaur@...com>
> ---
>  arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
> index 13e1d36123d5..d3bed23134ca 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
> @@ -249,7 +249,7 @@ AM62X_IOPAD(0x12c, PIN_OUTPUT, 0) /* (AD19/V15) RGMII1_TX_CTL */
>  
>  	main_usb1_pins_default: main-usb1-default-pins {
>  		pinctrl-single,pins = <
> -			AM62X_IOPAD(0x0258, PIN_OUTPUT | PIN_DS_PULLUD_ENABLE | PIN_DS_PULL_UP, 0) /* (F18/E16) USB1_DRVVBUS */
> +			AM62X_IOPAD(0x0258, PIN_OUTPUT, 0) /* (F18/E16) USB1_DRVVBUS */
>  		>;
>  	};
>  

Sorry for the long review on the commit message, but context feels like
everything when it comes to small patches. Hence trying to make sure
everyone understands what's being done here... :)

-- 
Best regards,
Dhruva Gole
Texas Instruments Incorporated