lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <aJyQevLQIs3Z1WVI@smile.fi.intel.com>
Date: Wed, 13 Aug 2025 16:17:46 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Liao Yuanhong <liaoyuanhong@...o.com>
Cc: Linus Walleij <linus.walleij@...aro.org>,
	Rahul Tanwar <rahul.tanwar@...ux.intel.com>,
	"open list:PIN CONTROL SUBSYSTEM" <linux-gpio@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: equilibrium: Remove redundant semicolons

On Tue, Aug 12, 2025 at 03:54:44PM +0800, Liao Yuanhong wrote:
> Remove unnecessary semicolons.

While this is a good one
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...el.com>

...

>  	raw_spin_unlock_irqrestore(&pctl->lock, flags);
>  	*config = pinconf_to_config_packed(param, val);
> -;
>  	return 0;


...I would still keep a blank line before return. But I leave it to Linus to
decide or even amend when applying.

-- 
With Best Regards,
Andy Shevchenko



Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ