linux-kernel - Re: [PATCH] tee: Use SHA-1 library instead of crypto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHUa44H1V0qR7omO8KpNxaW_bkXZAbaka=8r-zp+f6vdYs6fQQ@mail.gmail.com>
Date: Wed, 13 Aug 2025 15:43:57 +0200
From: Jens Wiklander <jens.wiklander@...aro.org>
To: Sumit Garg <sumit.garg@...nel.org>
Cc: Eric Biggers <ebiggers@...nel.org>, op-tee@...ts.trustedfirmware.org, 
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tee: Use SHA-1 library instead of crypto_shash

On Mon, Aug 11, 2025 at 8:13 AM Sumit Garg <sumit.garg@...nel.org> wrote:
>
> On Fri, Aug 01, 2025 at 04:55:41PM -0700, Eric Biggers wrote:
> > Use the SHA-1 library functions instead of crypto_shash.  This is
> > simpler and faster.
> >
> > Change uuid_v5() to return void, since it can no longer fail.
> >
> > Signed-off-by: Eric Biggers <ebiggers@...nel.org>
> > ---
> >
> > Note: this patch depends on the SHA-1 library functions that were merged
> > in v6.17-rc1.
> >
> >  drivers/tee/Kconfig    |  3 +--
> >  drivers/tee/tee_core.c | 55 +++++++-----------------------------------
> >  2 files changed, 10 insertions(+), 48 deletions(-)
>
> Nice cleanup, FWIW:
>
> Reviewed-by: Sumit Garg <sumit.garg@....qualcomm.com>

Looks good. I'm picking up this.

Thanks,
Jens