linux-kernel - RE: [PATCH v13 5/5] x86/sgx: Enable automatic SVN updates for SGX enclaves

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM8PR11MB5750D8CD3471F8F191B4AA69E72AA@DM8PR11MB5750.namprd11.prod.outlook.com>
Date: Wed, 13 Aug 2025 13:53:10 +0000
From: "Reshetova, Elena" <elena.reshetova@...el.com>
To: "Huang, Kai" <kai.huang@...el.com>, "Hansen, Dave" <dave.hansen@...el.com>
CC: "seanjc@...gle.com" <seanjc@...gle.com>, "mingo@...nel.org"
	<mingo@...nel.org>, "Scarlata, Vincent R" <vincent.r.scarlata@...el.com>,
	"x86@...nel.org" <x86@...nel.org>, "jarkko@...nel.org" <jarkko@...nel.org>,
	"Annapurve, Vishal" <vannapurve@...gle.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "Mallick, Asit K" <asit.k.mallick@...el.com>,
	"Aktas, Erdem" <erdemaktas@...gle.com>, "Cai, Chong" <chongc@...gle.com>,
	"Bondarevska, Nataliia" <bondarn@...gle.com>, "linux-sgx@...r.kernel.org"
	<linux-sgx@...r.kernel.org>, "Raynor, Scott" <scott.raynor@...el.com>
Subject: RE: [PATCH v13 5/5] x86/sgx: Enable automatic SVN updates for SGX
 enclaves



> -----Original Message-----
> From: Huang, Kai <kai.huang@...el.com>
> Sent: Wednesday, August 13, 2025 2:08 PM
> To: Reshetova, Elena <elena.reshetova@...el.com>; Hansen, Dave
> <dave.hansen@...el.com>
> Cc: seanjc@...gle.com; mingo@...nel.org; Scarlata, Vincent R
> <vincent.r.scarlata@...el.com>; x86@...nel.org; jarkko@...nel.org;
> Annapurve, Vishal <vannapurve@...gle.com>; linux-kernel@...r.kernel.org;
> Mallick, Asit K <asit.k.mallick@...el.com>; Aktas, Erdem
> <erdemaktas@...gle.com>; Cai, Chong <chongc@...gle.com>; Bondarevska,
> Nataliia <bondarn@...gle.com>; linux-sgx@...r.kernel.org; Raynor, Scott
> <scott.raynor@...el.com>
> Subject: Re: [PATCH v13 5/5] x86/sgx: Enable automatic SVN updates for SGX
> enclaves
> 
> >
> > Note: while in such cases the underlying crypto assets are regenrated, it
> 							     ^
> 							     regenerated
> 
> 

Thank you for catching this! Will fix. 

> [...]
> 
> > +/* Mutex to ensure no concurrent EPC accesses during EUPDATESVN */
> > +static DEFINE_MUTEX(sgx_svn_lock);
> > +
> >  int sgx_inc_usage_count(void)
> >  {
> > +	int ret;
> > +
> > +	guard(mutex)(&sgx_svn_lock);
> > +
> > +	if (sgx_usage_count++ == 0) {
> > +		ret = sgx_update_svn();
> > +		if (ret)
> > +			sgx_usage_count--;
> > +		return ret;
> > +	}
> > +
> 
> To me, I would prefer:
> 
> int sgx_inc_usage_count(void)
> {
> 	guard(mutex)(&sgx_svn_lock);
> 
> 	if (!sgx_usage_count) {
> 		int ret = sgx_update_svn();
> 		if (ret)
> 			return ret;
> 	}
> 
> 	sgx_usage_count++;
> 
> 	return 0;
> }

I can change to this version, but functionality-wise
it is equal. 

Best Regards,
Elena.