linux-kernel - Re: [PATCH 5/5] wifi: mwifiex: use vmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aJxaBzZYr4d5-XUv@stanley.mountain>
Date: Wed, 13 Aug 2025 12:25:27 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Qianfeng Rong <rongqianfeng@...o.com>
Cc: Brian Norris <briannorris@...omium.org>,
	Francesco Dolcini <francesco@...cini.it>,
	Johannes Berg <johannes.berg@...el.com>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Kalle Valo <kvalo@...nel.org>,
	Aditya Kumar Singh <quic_adisi@...cinc.com>,
	Rameshkumar Sundaram <quic_ramess@...cinc.com>,
	Roopni Devanathan <quic_rdevanat@...cinc.com>,
	"open list:MARVELL MWIFIEX WIRELESS DRIVER" <linux-wireless@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 5/5] wifi: mwifiex: use vmalloc_array() to simplify code

On Wed, Aug 13, 2025 at 02:52:51PM +0800, Qianfeng Rong wrote:
> > 
> > I really think we should zero this memory, so lets allocate it
> > with kcalloc().
> I agree with you, I will try to do this in the next version.

Thanks.  When you resend it make sure to add a Fixes tag and CC stable.
Forgetting to zero the memory is a sort of security issue.

regards,
dan carpenter