linux-kernel - Re: [PATCH net-next V3 8/9] eth: fbnic: Collect packet statistics for XDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250813073117.1bca3a97@kernel.org>
Date: Wed, 13 Aug 2025 07:31:17 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Mohsin Bashir <mohsin.bashr@...il.com>
Cc: netdev@...r.kernel.org, aleksander.lobakin@...el.com,
 alexanderduyck@...com, andrew+netdev@...n.ch, ast@...nel.org,
 bpf@...r.kernel.org, corbet@....net, daniel@...earbox.net,
 davem@...emloft.net, edumazet@...gle.com, hawk@...nel.org,
 horms@...nel.org, john.fastabend@...il.com, kernel-team@...a.com,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, pabeni@...hat.com,
 sdf@...ichev.me, vadim.fedorenko@...ux.dev
Subject: Re: [PATCH net-next V3 8/9] eth: fbnic: Collect packet statistics
 for XDP

On Tue, 12 Aug 2025 15:22:52 -0700 Mohsin Bashir wrote:
> +				} else if (PTR_ERR(skb) == -FBNIC_XDP_LEN_ERR) {
> +					length_errors++;

cocci is complaining about this:

...fbnic_txrx.c:1264:14-21: ERROR: PTR_ERR applied after initialization to constant on line 1250

I think applying PTR_ERR/ERR_PTR to the constant may clean this up.
-- 
pw-bot: cr