linux-kernel - Re: [PATCH] PCI: hv: Remove unused parameter of hv_msi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aJyjtvNabuXc1xhX@liuwe-devbox-ubuntu-v2.tail21d00.ts.net>
Date: Wed, 13 Aug 2025 14:39:50 +0000
From: Wei Liu <wei.liu@...nel.org>
To: Nam Cao <namcao@...utronix.de>
Cc: "K . Y . Srinivasan" <kys@...rosoft.com>,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
	Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Krzysztof Wilczyński <kwilczynski@...nel.org>,
	Manivannan Sadhasivam <mani@...nel.org>,
	Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
	linux-hyperv@...r.kernel.org, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: hv: Remove unused parameter of hv_msi_free()

On Wed, Aug 13, 2025 at 07:53:50AM +0200, Nam Cao wrote:
> The 'info' parameter of hv_msi_free() is unused. Delete it.
> 
> Signed-off-by: Nam Cao <namcao@...utronix.de>

Acked-by: Wei Liu <wei.liu@...nel.org>

I assume this will go through the PCI tree.

> ---
>  drivers/pci/controller/pci-hyperv.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
> index d2b7e8ea710b..146b43981b27 100644
> --- a/drivers/pci/controller/pci-hyperv.c
> +++ b/drivers/pci/controller/pci-hyperv.c
> @@ -1680,7 +1680,6 @@ static void hv_int_desc_free(struct hv_pci_dev *hpdev,
>  /**
>   * hv_msi_free() - Free the MSI.
>   * @domain:	The interrupt domain pointer
> - * @info:	Extra MSI-related context
>   * @irq:	Identifies the IRQ.
>   *
>   * The Hyper-V parent partition and hypervisor are tracking the
> @@ -1688,8 +1687,7 @@ static void hv_int_desc_free(struct hv_pci_dev *hpdev,
>   * table up to date.  This callback sends a message that frees
>   * the IRT entry and related tracking nonsense.
>   */
> -static void hv_msi_free(struct irq_domain *domain, struct msi_domain_info *info,
> -			unsigned int irq)
> +static void hv_msi_free(struct irq_domain *domain, unsigned int irq)
>  {
>  	struct hv_pcibus_device *hbus;
>  	struct hv_pci_dev *hpdev;
> @@ -2181,10 +2179,8 @@ static int hv_pcie_domain_alloc(struct irq_domain *d, unsigned int virq, unsigne
>  
>  static void hv_pcie_domain_free(struct irq_domain *d, unsigned int virq, unsigned int nr_irqs)
>  {
> -	struct msi_domain_info *info = d->host_data;
> -
>  	for (int i = 0; i < nr_irqs; i++)
> -		hv_msi_free(d, info, virq + i);
> +		hv_msi_free(d, virq + i);
>  
>  	irq_domain_free_irqs_top(d, virq, nr_irqs);
>  }
> -- 
> 2.39.5
>