linux-kernel - Re: [PATCH v2 2/2] soc: ti: ti_sci_inta_msi: Enable module compilation support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250813152610.akcdxrzhev6e2kfa@unturned>
Date: Wed, 13 Aug 2025 10:26:10 -0500
From: Nishanth Menon <nm@...com>
To: Guillaume La Roque <glaroque@...libre.com>
CC: Thomas Gleixner <tglx@...utronix.de>, <vigneshr@...com>,
        Santosh Shilimkar
	<ssantosh@...nel.org>,
        Tero Kristo <kristo@...nel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 2/2] soc: ti: ti_sci_inta_msi: Enable module
 compilation support

On 22:36-20250812, Guillaume La Roque wrote:
> Add module support to the TI SCI INTA MSI driver:
> - Change Kconfig from bool to tristate to allow module compilation
> - Add linux/module.h include for module functionality
> - Add MODULE_LICENSE, MODULE_DESCRIPTION, and MODULE_AUTHOR macros
> 
> This allows the driver to be compiled as a loadable kernel module
> named ti_sci_inta_msi.
> 
> Signed-off-by: Guillaume La Roque <glaroque@...libre.com>
> ---
>  drivers/soc/ti/Kconfig           | 5 ++++-
>  drivers/soc/ti/ti_sci_inta_msi.c | 5 +++++
>  2 files changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/ti/Kconfig b/drivers/soc/ti/Kconfig
> index 1a93001c9e36..0a9eb5ac264b 100644
> --- a/drivers/soc/ti/Kconfig
> +++ b/drivers/soc/ti/Kconfig
> @@ -85,7 +85,10 @@ config TI_PRUSS
>  endif # SOC_TI
>  
>  config TI_SCI_INTA_MSI_DOMAIN
> -	bool
> +	tristate "TI SCI INTA MSI Domain driver"
>  	select GENERIC_MSI_IRQ
>  	help
>  	  Driver to enable Interrupt Aggregator specific MSI Domain.
> +
> +	  Say Y here to compile it into the kernel or M to compile it as a
> +	  module. The module will be called ti_sci_inta_msi.
> diff --git a/drivers/soc/ti/ti_sci_inta_msi.c b/drivers/soc/ti/ti_sci_inta_msi.c
> index 193266f5e3f9..d92cab319d57 100644
> --- a/drivers/soc/ti/ti_sci_inta_msi.c
> +++ b/drivers/soc/ti/ti_sci_inta_msi.c
> @@ -8,6 +8,7 @@
>  
>  #include <linux/irq.h>
>  #include <linux/irqdomain.h>
> +#include <linux/module.h>
>  #include <linux/msi.h>
>  #include <linux/of.h>
>  #include <linux/of_address.h>
> @@ -115,3 +116,7 @@ int ti_sci_inta_msi_domain_alloc_irqs(struct device *dev,
>  	return ret;
>  }
>  EXPORT_SYMBOL_GPL(ti_sci_inta_msi_domain_alloc_irqs);
> +
> +MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("Texas Instruments K3 Interrupt Aggregator MSI bus");
> +MODULE_AUTHOR("Lokesh Vutla <lokeshvutla@...com>");
> 
> -- 
> 2.34.1
> 

If Thomas doesn't mind picking the full series,

Acked-by: Nishanth Menon <nm@...com>

This is probably one of the last hold outs for us to move SoC support
into kernel modules.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
https://ti.com/opensource