linux-kernel - Re: [PATCH] ALSA: hda: Improve local variable data type in snd_hda_get_num

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87cy8zw7ia.wl-tiwai@suse.de>
Date: Wed, 13 Aug 2025 17:45:01 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	Julia Lawall <Julia.Lawall@...ia.fr>,
	"Dr. David Alan Gilbert" <linux@...blig.org>,
	Wentao Liang <vulab@...as.ac.cn>,
	Takashi Iwai <tiwai@...e.de>,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: hda: Improve local variable data type in snd_hda_get_num_devices()

On Wed, 13 Aug 2025 12:34:16 +0200,
Thorsten Blum wrote:
> 
> Use 'int' instead of 'unsigned int' because the local variable 'parm'
> can be negative.
> 
> While an unsigned integer is harmless in practice due to the implicit
> type conversion, it's safer and more idiomatic to use a signed integer
> to properly check for -1.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>

Applied now.  Thanks.


Takashi