linux-kernel - Re: [PATCH v1] ALSA: hda/tas2781: Normalize the volume kcontrol name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ectfw7j5.wl-tiwai@suse.de>
Date: Wed, 13 Aug 2025 17:44:30 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Baojun Xu <baojun.xu@...com>
Cc: <broonie@...nel.org>,
	<andriy.shevchenko@...ux.intel.com>,
	<alsa-devel@...a-project.org>,
	<shenghao-ding@...com>,
	<13916275206@....com>,
	<linux-sound@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] ALSA: hda/tas2781: Normalize the volume kcontrol name

On Wed, 13 Aug 2025 12:08:42 +0200,
Baojun Xu wrote:
> 
> Change the name of the kcontrol from "Gain" to "Volume".

Could you describe "why this change is needed"?


thanks,

Takashi

> 
> Signed-off-by: Baojun Xu <baojun.xu@...com>
> ---
>  sound/hda/codecs/side-codecs/tas2781_hda_i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/hda/codecs/side-codecs/tas2781_hda_i2c.c b/sound/hda/codecs/side-codecs/tas2781_hda_i2c.c
> index 92aae19cfc8f..e4bc3bc756b0 100644
> --- a/sound/hda/codecs/side-codecs/tas2781_hda_i2c.c
> +++ b/sound/hda/codecs/side-codecs/tas2781_hda_i2c.c
> @@ -256,7 +256,7 @@ static const struct snd_kcontrol_new tas2770_snd_controls[] = {
>  };
>  
>  static const struct snd_kcontrol_new tas2781_snd_controls[] = {
> -	ACARD_SINGLE_RANGE_EXT_TLV("Speaker Analog Gain", TAS2781_AMP_LEVEL,
> +	ACARD_SINGLE_RANGE_EXT_TLV("Speaker Analog Volume", TAS2781_AMP_LEVEL,
>  		1, 0, 20, 0, tas2781_amp_getvol,
>  		tas2781_amp_putvol, amp_vol_tlv),
>  	ACARD_SINGLE_BOOL_EXT("Speaker Force Firmware Load", 0,
> -- 
> 2.43.0
>