lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAHp75VcG0PoZZQ+=DNqzvdJrTcGe=2V5H97vhter4zeOQz1e2A@mail.gmail.com>
Date: Wed, 13 Aug 2025 18:34:33 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Ben Collins <bcollins@...ter.com>
Cc: Jonathan Cameron <jic23@...nel.org>, David Lechner <dlechner@...libre.com>, 
	Nuno Sá <nuno.sa@...log.com>, 
	Andy Shevchenko <andy@...nel.org>, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/5] iio: mcp9600: White space cleanup for tab alignment

On Wed, Aug 13, 2025 at 5:17 PM Ben Collins <bcollins@...ter.com> wrote:
>
> Purely to align tabs for #defines.

...

> +#define MCP9600_HOT_JUNCTION           0x0
> +#define MCP9600_COLD_JUNCTION          0x2
>  #define MCP9600_STATUS                 0x4

>  #define MCP9600_ALERT_CFG1             0x8

I would also suggest making the register offsets to be fixed-width, e.g.
0x04 for STATUS. And since these are the most lines you are already
touching in this patch, repurpose it.

-- 
With Best Regards,
Andy Shevchenko

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ