linux-kernel - Re: [RFC PATCH -next 12/16] mm/damon: add damon_ctx->min_region and damon_target->min

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250813164907.5885-1-sj@kernel.org>
Date: Wed, 13 Aug 2025 09:49:07 -0700
From: SeongJae Park <sj@...nel.org>
To: Quanmin Yan <yanquanmin1@...wei.com>
Cc: SeongJae Park <sj@...nel.org>,
	akpm@...ux-foundation.org,
	damon@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	linux-mm@...ck.org,
	wangkefeng.wang@...wei.com,
	zuoze1@...wei.com
Subject: Re: [RFC PATCH -next 12/16] mm/damon: add damon_ctx->min_region and damon_target->min_region

On Wed, 13 Aug 2025 13:07:02 +0800 Quanmin Yan <yanquanmin1@...wei.com> wrote:

> Adopting addr_unit would make DAMON_MINREGION 'addr_unit * 4096'
> bytes and cause data alignment issues[1].
> 
> Add damon_ctx->min_region to change DAMON_MIN_REGION from a global
> macro value to per-context variable,

Nice!

> let target inherit the min_region
> from its associated ctx to avoid excessive passing of ctx.

To me, keeping the synchronization seems more complicated than just passing the
addr_unit value to relevant functions.  I'd prefer passing the addr_unit to
relevant functions.  It could require more changes and might make code uglier,
but I think that's easier to maintain, and we can cleanup/refactor the code
later.

Could you please do so in the next version?


Thanks,
SJ

[...]