[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20250813-ltc2495-v2-0-bbaf20f6ba07@gmail.com>
Date: Wed, 13 Aug 2025 18:54:28 +0200
From: Yusuf Alper Bilgin <y.alperbilgin@...il.com>
To: Lars-Peter Clausen <lars@...afoo.de>,
Michael Hennerich <Michael.Hennerich@...log.com>,
Jonathan Cameron <jic23@...nel.org>, David Lechner <dlechner@...libre.com>,
Nuno Sá <nuno.sa@...log.com>,
Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Liam Beguin <liambeguin@...il.com>
Cc: Michael Hennerich <michael.hennerich@...log.com>,
linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, Yusuf Alper Bilgin <y.alperbilgin@...il.com>
Subject: [PATCH v2 0/4] Add LTC2495 support
Hi All,
This is the v2 of the patch series to add support for the LTC2495 ADC to
the ltc2497 driver and to enable the internal temperature channel for
the LTC2495 and LTC2499.
Many thanks to Andy Shevchenko and Krzysztof Kozlowski for their
detailed and helpful reviews on v1. I believe I've addressed all
feedbacks in this version.
Best Regards,
Alper
Signed-off-by: Yusuf Alper Bilgin <y.alperbilgin@...il.com>
---
Changes in v2:
- Rewrote all commit messages to use the imperative mood.
- Added a justification for the new compatible string to the device
tree binding commit message.
- Removed all unrelated whitespace and formatting changes.
- Removed redundant explicit `false` initializers from structs.
- Replaced the magic number for Kelvin conversion with a define.
- Improved comments for defines and temperature scaling constants.
- Renamed confusing macros and struct fields to be more descriptive.
- Replaced dynamic channel allocation with a static array approach
using a shared macro to improve readability.
- Optimized data structure layouts based on pahole output to remove
memory holes.
- Link to v1: https://lore.kernel.org/r/20250812-ltc2495-v1-0-7bf4c6feec2e@gmail.com
---
Implementation Notes
- checkpatch warning: The new static array approach uses a shared macro
for the common channels (`LTC2497_CHANNELS`), which triggers a
checkpatch.pl warning: "Macros with complex values should be enclosed
in parentheses". However, this will cause a compilitaion error, as an
initializer list cannot be parenthesized.
- uV to mV conversion: I could not find a standard macro, so a manual
division is used for now. This could be a point of future
improvement.
---
Yusuf Alper Bilgin (4):
dt-bindings: iio: adc: ltc2497: add lltc,ltc2495 bindings
iio: adc: ltc2497: add support for LTC2495
iio: adc: ltc2497: add temperature sensor support
iio: adc: ltc2497: reorder ltc2497core_driverdata members to remove hole
.../devicetree/bindings/iio/adc/lltc,ltc2497.yaml | 3 +
drivers/iio/adc/ltc2497-core.c | 140 +++++++++++++++------
drivers/iio/adc/ltc2497.c | 35 +++++-
drivers/iio/adc/ltc2497.h | 23 +++-
4 files changed, 158 insertions(+), 43 deletions(-)
---
base-commit: acbbb5a20971089064ca6b271dd251e629be8d4d
change-id: 20250811-ltc2495-572817c13fd3
Best regards,
--
Yusuf Alper Bilgin <y.alperbilgin@...il.com>
Powered by blists - more mailing lists